GriptapeCloudVectorStoreDriver #885
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ready for general review but not final form until 28 is finalized |
collindutter
requested changes
Jul 10, 2024
Comment on lines
93
to
100
| if count is not None: | ||
| request["count"] = count | ||
| if distance_metric is not None: | ||
| request["distance_metric"] = distance_metric | ||
| if filter is not None: | ||
| request["filter"] = filter | ||
| if include_vectors is not None: | ||
| request["include_vectors"] = include_vectors |
There was a problem hiding this comment.
Maybe refactor to use this syntax?
Comment on lines
15
to
37
| test_ids = [str(uuid.uuid4()), str(uuid.uuid4())] | ||
| test_vecs = [[0.1, 0.2, 0.3], [0.4, 0.5, 0.6]] | ||
| test_namespaces = [str(uuid.uuid4()), str(uuid.uuid4())] | ||
| test_metas = [{"key": "value1"}, {"key": "value2"}] | ||
| test_scores = [0.7, 0.8] | ||
| test_entries = { | ||
| "entries": [ | ||
| { | ||
| "id": test_ids[0], | ||
| "vector": test_vecs[0], | ||
| "namespace": test_namespaces[0], | ||
| "meta": test_metas[0], | ||
| "score": test_scores[0], | ||
| }, | ||
| { | ||
| "id": test_ids[1], | ||
| "vector": test_vecs[1], | ||
| "namespace": test_namespaces[1], | ||
| "meta": test_metas[1], | ||
| "score": test_scores[1], | ||
| }, | ||
| ] | ||
| } |
There was a problem hiding this comment.
Move into mock_requests_post
Comment on lines
41
to
42
| def mock_requests_post(*args, **kwargs): | ||
| return MockResponse(test_entries, 200) |
| @@ -49,6 +49,30 @@ print("\n\n".join(values)) | |||
|
|
|||
| ``` | |||
|
|
|||
| ### Griptape Cloud Knowledge Base | |||
|
|
|||
| The [GriptapeCloudKnowledgeBaseVectorStoreDriver](../../reference/griptape/drivers/vector/griptape_cloud_knowledge_base_vector_store_driver.md) can be used to query data from a Griptape Cloud Knowledge Base. Loading into Knowledge Bases is not support, only querying. Here is a complete example of how the driver can be used to query an existing Knowledge Base: | |||
There was a problem hiding this comment.
is not support -> is not supported at this time.
driver -> Driver
There was a problem hiding this comment.
Do we really want Driver capitalized, it isn't for rest of entries (can update all if we want)
|
|
||
| @pytest.fixture | ||
| def driver(self, mocker): | ||
| from griptape.drivers import GriptapeCloudKnowledgeBaseVectorStoreDriver |
| import uuid | ||
|
|
||
|
|
||
| class MockResponse: |
collindutter
previously approved these changes
Jul 11, 2024
collindutter
approved these changes
Jul 12, 2024
collindutter
approved these changes
Jul 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.