Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix integration tests; Update PromptTask input validation #931

Merged
merged 5 commits into from
Jul 2, 2024
Merged

Conversation

vachillo
Copy link
Member

@vachillo vachillo commented Jul 2, 2024

Describe your changes

  • fixing failing integration tests
  • update input validation on PromptTask
  • update default vector_id to a namespaced uuid5 using the vector content

Issue ticket number and link

Checklist before requesting a review

  • I have performed a self-review of my code.
  • I have added thorough tests.
  • Is this a notable change? If so, please update the changelog.

📚 Documentation preview 📚: https://griptape--931.org.readthedocs.build//931/

@vachillo vachillo changed the title Fix integration tests Fix integration tests; Update PromptTask input validation Jul 2, 2024
collindutter
collindutter previously approved these changes Jul 2, 2024
Copy link

codecov bot commented Jul 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

@vachillo vachillo merged commit 7487441 into dev Jul 2, 2024
12 checks passed
@vachillo vachillo deleted the integ_tests branch July 2, 2024 23:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants