Update ruff linter rules according to documentation #940
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is 📢 Thoughts on this report? Let us know! |
collindutter
requested review from
vasinov,
vachillo and
dylanholmes
and removed request for
a team
collindutter
force-pushed
the
fix/ruff-rules
branch
2 times, most recently
from
ec06bb0 to
7266f64
Compare
|
I'm on the fence about SIM108, but I think i'm leaning towards including it for consistency. |
collindutter
force-pushed
the
fix/ruff-rules
branch
from
7266f64 to
db8a2e4
Compare
collindutter
force-pushed
the
fix/ruff-rules
branch
from
db8a2e4 to
bc3505b
Compare
dylanholmes
approved these changes
Jul 5, 2024
| @@ -55,7 +55,7 @@ def try_load_file(self, path: str) -> bytes: | |||
| return response["Body"].read() | |||
| except botocore.exceptions.ClientError as e: | |||
| if e.response["Error"]["Code"] in {"NoSuchKey", "404"}: | |||
| raise FileNotFoundError | |||
| raise FileNotFoundError from e | |||
There was a problem hiding this comment.
TIL - I've actually never seen this syntax before, cool!
| @@ -200,7 +200,22 @@ line-length = 120 | |||
| skip-magic-trailing-comma = true | |||
|
|
|||
| [tool.ruff.lint] | |||
| select = ["E4", "E7", "E9", "F", "TID251"] | |||
| select = [ | |||
| "E", # pycodestyle | |||
There was a problem hiding this comment.
Thanks for adding the comments!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Enables more ruff linting rules as suggested by the documentation. Also disables some that interfere with some core functionality. We can evaluate removing these in the future.
Issue ticket number and link
NA.