Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add default for GriptapeCloudEventListenerDriver.api_key #990

Merged
merged 2 commits into from
Jul 16, 2024

Conversation

dylanholmes
Copy link
Contributor

@dylanholmes dylanholmes commented Jul 16, 2024

Changes:

  • GriptapeCloudEventListenerDriver.api_key defaults to os.getenv("GT_CLOUD_API_KEY")
  • Fix pyright warning
  • Edit GriptapeCloudEventListenerDriver usage docs
  • Add GT_CLOUD_API_KEY integration test env var

📚 Documentation preview 📚: https://griptape--990.org.readthedocs.build//990/

@dylanholmes dylanholmes requested a review from collindutter July 16, 2024 22:27
collindutter
collindutter previously approved these changes Jul 16, 2024
Copy link

codecov bot commented Jul 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

@collindutter
Copy link
Member

I'm fine ignoring the code cov

@dylanholmes dylanholmes force-pushed the feature/api-key-default branch from 65f596a to 274a939 Compare July 16, 2024 23:06
@dylanholmes dylanholmes requested a review from collindutter July 16, 2024 23:27
@collindutter collindutter marked this pull request as ready for review July 16, 2024 23:28
@dylanholmes dylanholmes merged commit 7c13601 into dev Jul 16, 2024
12 checks passed
@dylanholmes dylanholmes deleted the feature/api-key-default branch July 16, 2024 23:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants