Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add grisp pack command #28

Merged
merged 2 commits into from
Sep 6, 2024
Merged

Add grisp pack command #28

merged 2 commits into from
Sep 6, 2024

Conversation

sylane
Copy link
Contributor

@sylane sylane commented Sep 5, 2024

Required by grisp/rebar3_grisp#85

@sylane
Copy link
Contributor Author

sylane commented Sep 5, 2024

The dependency will be fixed when testing and review is done, and I can publish grisp_update_packager

@sylane sylane force-pushed the sylane/pack-command branch from 0b4201e to 8135376 Compare September 5, 2024 16:30
Copy link
Member

@ziopio ziopio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

REmember to cross link this PR with its rebar3_grisp sibling

CHANGELOG.md Outdated Show resolved Hide resolved
src/grisp_tools.hrl Outdated Show resolved Hide resolved
src/grisp_tools.hrl Show resolved Hide resolved
@sylane
Copy link
Contributor Author

sylane commented Sep 6, 2024

REmember to cross link this PR with its rebar3_grisp sibling

@ziopio Do you mean here in the PR description or somewhere else ?

@ziopio
Copy link
Member

ziopio commented Sep 6, 2024

@sylane cross link the PRs in their description so it is easy to navigate between them and find them in future

@ziopio ziopio self-requested a review September 6, 2024 15:51
@sylane sylane force-pushed the sylane/pack-command branch from 4719c3b to fd0a537 Compare September 6, 2024 16:18
@sylane sylane merged commit 7f61278 into master Sep 6, 2024
10 checks passed
@sylane sylane deleted the sylane/pack-command branch September 6, 2024 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants