Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Failing build if translation files contain invalid values #1367

Merged
merged 3 commits into from
Jan 7, 2025
Merged

Failing build if translation files contain invalid values #1367

merged 3 commits into from
Jan 7, 2025

Conversation

berhalak
Copy link
Contributor

@berhalak berhalak commented Jan 7, 2025 •
edited
Loading

Context

Latest PR #1354 was breaking docker build and took the wrong approach for sanitizing translation files. More in the comments.

Proposed solution

  1. Docker build was fixed by copying translation files sooner (just for validating them).
  2. Build now only fails if some translations keys have values with invalid tags. Previously it was fixing them.

Related issues

#1350
#1354
#1361

Has this been tested?

  • 👍 yes, I added tests to the test suite
  • 💭 no, because this PR is a draft and still needs work
  • 🙅 no, because this is not relevant here
  • 🙋 no, because I need help

@berhalak berhalak mentioned this pull request Jan 7, 2025
Merged
fflorent
fflorent approved these changes Jan 7, 2025
View reviewed changes
Copy link
Collaborator

@fflorent fflorent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

buildtools/sanitize_translations.js Outdated Show resolved Hide resolved
@fflorent fflorent mentioned this pull request Jan 7, 2025
Closed
2 tasks
@fflorent
Copy link
Collaborator

fflorent commented Jan 7, 2025 •
edited
Loading

The fix of this PR is necessary so I can test my latest changes in #1247

@paulfitz paulfitz self-requested a review January 7, 2025 20:04
paulfitz
paulfitz approved these changes Jan 7, 2025
View reviewed changes
Copy link
Member

@paulfitz paulfitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @berhalak

@paulfitz paulfitz merged commit dd6c093 into main Jan 7, 2025
12 checks passed
@paulfitz paulfitz deleted the failing-build-on-invalid-translations branch January 7, 2025 20:12
@paulfitz paulfitz mentioned this pull request Jan 7, 2025
Open
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fflorent fflorent fflorent approved these changes

@paulfitz paulfitz paulfitz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@berhalak @fflorent @paulfitz