Upgrade Dependency connect-redis from 3.4.0 to 6.1.3 #1387
Merged
+22
−34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hexaltation
added
dependencies
hexaltation
force-pushed
the
dependencies-update-connect-redis
branch
from
633d761 to
43adde8
Compare
hexaltation
changed the title
hexaltation
changed the title
hexaltation
force-pushed
the
dependencies-update-connect-redis
branch
2 times, most recently
from
17cf0dc to
ec019cd
Compare
The purpose is to remove a vulnerable version of redis from dependencies of connect-redis. the choosen version is the one updating node-redis to a safe version
hexaltation
force-pushed
the
dependencies-update-connect-redis
branch
from
ec019cd to
72d3d3c
Compare
hexaltation
changed the title
hexaltation
commented
Mar 4, 2025
hexaltation
commented
Mar 4, 2025
fflorent
approved these changes
Mar 4, 2025
Importing this way, it's the declaration.d.ts that is used. Thats why I added unref in it.
fflorent
approved these changes
Mar 5, 2025
dsagal
reviewed
Mar 5, 2025
6.1.3 is choosen cause it's the last version supporting redis@v3
While the redis version was not fixed, produced Docker images onboard 3.1.0 instead of >= 3.1.1.
hexaltation
commented
Mar 6, 2025
| @@ -197,7 +197,7 @@ | |||
| "prom-client": "14.2.0", | |||
| "qrcode": "1.5.0", | |||
| "randomcolor": "0.5.3", | |||
| "redis": "3.1.1", | |||
| "redis": "~3.1.2", | |||
There was a problem hiding this comment.
While the redis version was not prefixed with ~, produced Docker images contained
3.1.0 instead of >= 3.1.1.
hexaltation
commented
Mar 6, 2025
| @@ -142,7 +142,7 @@ | |||
| "color-convert": "2.0.1", | |||
| "commander": "9.3.0", | |||
| "components-jqueryui": "1.12.1", | |||
| "connect-redis": "3.4.0", | |||
| "connect-redis": "6.1.3", | |||
There was a problem hiding this comment.
This is the last version of connect-redis supporting redis@v3
hexaltation
requested review from
fflorent and
dsagal
and removed request for
georgegevoian
|
The CI error is a known flaky end-to-end test (importer2). |
hexaltation
changed the title
georgegevoian
approved these changes
Mar 6, 2025
There was a problem hiding this comment.
Confirming tests still pass in our internal CI after these changes.
Thanks @hexaltation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
This PR is a follow-up of #1368
It manage to upgrade redis-connect to it's latest release
Proposed solution
The following strategy has been chosen.
Bump connect-redis from 3.4.0 to 6.1.3
Applies migration following https://github.com/tj/connect-redis/blob/c951850eb72759f387d4ae0c249aca8e1e9fc244/migration-to-v4.md
Has this been tested?