Rename grist-electron to grist-desktop

[SleepyLeslie]

Successor of #36 with changes related to the config file reverted to keep backwards compatibility.
This includes some miscellaneous changes:

• Linting
• Code structure adjustment and cleanup
• More info about configuration in the README
• Package metadata correction
• Show Grist Desktop version in addition to the underlying Core version in --version

[paulfitz]

Thanks @SleepyLeslie ! Looks broadly reasonable. One case of code duplication I'd like to avoid if possible, I suggest something.

[paulfitz]

Oh wow, bluebird, this code must be old. What is the unsafety issue leading to this need for code duplication? Is it the TYPEORM_DATABASE issue? If so, how do you feel about factoring the method you need in grist-core out to a separate file that doesn't import anything awkward? It will be awkward in future to make sure bugfixes/improvements to this method end up going to the two copies.

[SleepyLeslie]

Thanks for bringing this again to my attention! A closer look suggests that the TYPEORM_DATABASE issue is an urban myth. I remember testing importing dbUtils before setting up TYPEORM_DATABASE and it didn't work, but it likely failed for some other reasons as I couldn't reproduce the failure now (and on the base commit as well). I just did more tests and as a conclusion it could be safely dismissed.

Will remove related hacks and comments. My bad for not catching it early on.

[SleepyLeslie]

Also, I read the dbUtils code, and logically believe that importing it is not supposed to have side effects.

[paulfitz]

Thanks for the clean-up! What role does test.db play?

[SleepyLeslie]

What role does test.db play?

Nothing. It slipped into my commit. Removed.

[paulfitz]

Thanks @SleepyLeslie !