Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

webhooks: add initial documentation #365

Merged
merged 1 commit into from
Jul 31, 2024
Merged

webhooks: add initial documentation #365

merged 1 commit into from
Jul 31, 2024

Conversation

jordigh
Copy link
Contributor

@jordigh jordigh commented Jul 22, 2024

No description provided.

Copy link

netlify bot commented Jul 22, 2024

Deploy Preview for grist-help-preview ready!

Name Link
🔨 Latest commit bf7b447
🔍 Latest deploy log https://app.netlify.com/sites/grist-help-preview/deploys/66a96b6ec1fc330008da8146
😎 Deploy Preview https://deploy-preview-365--grist-help-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@jordigh jordigh force-pushed the webhooks branch 6 times, most recently from 5debd78 to 6da07ff Compare July 23, 2024 22:00
Copy link
Contributor

@Spoffy Spoffy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, I learned a lot about how our webhooks work! 😁

That said, I'm also not familiar with them, so wouldn't be able to tell if anything was missing!

The only thing I'm wondering is if it's worth talking about how reference types are handled? The normal Grist API gives unusual arrays of IDs, rather than resolving and expanding the reference. Not sure if webhooks do the same, or if it's worth talking about.

Overall, really easy to read docs 🙂

help/en/docs/webhooks.md Outdated Show resolved Hide resolved
@nataliemisasi nataliemisasi self-requested a review July 24, 2024 13:29
Copy link
Collaborator

@nataliemisasi nataliemisasi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some formatting changes per our Grist Content Style Guide.

help/en/docs/webhooks.md Show resolved Hide resolved
help/en/docs/webhooks.md Outdated Show resolved Hide resolved
help/en/docs/webhooks.md Outdated Show resolved Hide resolved
help/en/docs/webhooks.md Outdated Show resolved Hide resolved
help/en/docs/webhooks.md Outdated Show resolved Hide resolved
help/en/docs/webhooks.md Outdated Show resolved Hide resolved
help/en/docs/webhooks.md Outdated Show resolved Hide resolved
help/en/docs/webhooks.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@georgegevoian georgegevoian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Thanks!

@jordigh jordigh merged commit 392ed00 into master Jul 31, 2024
5 checks passed
@jordigh jordigh deleted the webhooks branch July 31, 2024 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants