Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API: /docs/{docId}/move may move to a WS of a different org #369

Merged
merged 1 commit into from
Jul 31, 2024

Conversation

fflorent
Copy link
Sponsor Collaborator

Context

While looking at the API documentation, I read that the PATCH /docs/{docId}/move endpoint specifies that the doc may move to a workspace at the condition that it remains in the same org.

We would like to use this endpoint to move the document of an old account's personal org to a new account's one.

After having taken a look at the code and experimented, it looks like it is not the case.

Proposed solution

I simply remove the mention indicating that the target workspace should be in the same org as the source.

@fflorent fflorent changed the title API: /docs/{docId}/move may move to a WS of a different org [Tiny] API: /docs/{docId}/move may move to a WS of a different org Jul 31, 2024
Copy link

netlify bot commented Jul 31, 2024

Deploy Preview for grist-help-preview ready!

Name Link
🔨 Latest commit 4bda65e
🔍 Latest deploy log https://app.netlify.com/sites/grist-help-preview/deploys/66aa6b339fbd920008416fc2
😎 Deploy Preview https://deploy-preview-369--grist-help-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@fflorent fflorent changed the title [Tiny] API: /docs/{docId}/move may move to a WS of a different org API: /docs/{docId}/move may move to a WS of a different org Jul 31, 2024
Copy link
Member

@paulfitz paulfitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! The summary does seem to be simply wrong.

@fflorent fflorent merged commit b100902 into gristlabs:master Jul 31, 2024
5 checks passed
@fflorent fflorent deleted the fix-move-doc-endpoint branch July 31, 2024 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants