Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure Button label renders as correct light/dark color on primary + color Button #283

Open
taysea opened this issue Oct 7, 2022 · 0 comments

Comments

@taysea
Copy link
Collaborator

taysea commented Oct 7, 2022

<Button color="purple!" label="Feedback" /> 

renders with "black" text instead of previous "white" -- this is due to recent theme changes related to desired primary button label color when background is HPE green vs other colors.

Screen Shot 2022-10-07 at 4 29 19 PM

The theme should:

  1. Use text-primary-button when the primary Button is HPE green.
  2. Leverage button utils to determine which label color should be used when Button has primary and color applied instead of keying off of theme mode.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant