Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix label color of feedback button #2959

Merged
merged 2 commits into from
Oct 10, 2022
Merged

Conversation

taysea
Copy link
Collaborator

@taysea taysea commented Oct 10, 2022

Deploy Preview

What does this PR do?

Adjusts the label color of the feedback button via StyledComponent. Temp fix until grommet/grommet-theme-hpe#283 is resolved.

Also, fixes some linting errors on Layout page.

Where should the reviewer start?

What testing has been done on this PR?

In addition to the feature you are implementing, have you checked the following:

General UX Checks

  • Small, medium, and large screen sizes
  • Cross-browsers (FireFox, Chrome, and Safari)
  • Light & dark modes
  • All hyperlinks route properly

Accessibility Checks

  • Keyboard interactions
  • Screen reader experience
  • Run WAVE accessibility plugin (Chrome)

Code Quality Checks

  • Console is free of warnings and errors
  • Passes E2E commit checks
  • Visual snapshots are reasonable

How should this be manually tested?

Any background context you want to provide?

What are the relevant issues?

Screenshots (if appropriate)

Should this PR be mentioned in Design System updates?

Is this change backwards compatible or is it a breaking change?

@taysea taysea requested a review from halocline October 10, 2022 19:38
@halocline halocline merged commit 7c72001 into master Oct 10, 2022
@halocline halocline deleted the fix/feedback-button-label branch October 10, 2022 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants