Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Tag to use Close icon #363

Open
taysea opened this issue Jul 10, 2023 · 4 comments
Open

Update Tag to use Close icon #363

taysea opened this issue Jul 10, 2023 · 4 comments
Labels

Comments

@taysea
Copy link
Collaborator

taysea commented Jul 10, 2023

This ticket must wait until grommet/grommet#6870 is merged. Update Tag icon to use Close as opposed to FormClose.

@jcfilben
Copy link
Collaborator

jcfilben commented Dec 5, 2023

Changing the tag icon to Close results in an icon that look unpropotionally large in comparison with the text in the tag.

Tag with Close icon
Screen Shot 2023-12-05 at 2 09 04 PM

Tag with FormClose icon (this is what is currently implemented)
Screen Shot 2023-12-05 at 2 09 14 PM

Pulling this issue back from this sprint. We need to look into the icon sizing more and determine what is the correct size to use with Tag.

@jcfilben jcfilben removed their assignment Dec 5, 2023
@MikeKingdom
Copy link
Collaborator

Greg chose the FormClose icon when he originally designed the Tag partly for this reason.

Why do we currently feel it should be the bigger icon? Affecting the height of the Tag will cause alot of problems.

@jcfilben
Copy link
Collaborator

jcfilben commented Dec 7, 2023

I think the desire is for the HPE theme to no longer use the 'Form' icons. But agree this causes issues with Tag. Seems like we need to have more design discussion here before moving forward with this.

@halocline
Copy link
Collaborator

I think the desire is for the HPE theme to no longer use the 'Form' icons. But agree this causes issues with Tag. Seems like we need to have more design discussion here before moving forward with this.

Or, theme does something like

icon: <Close />,
size: 'small'

Don't know if that is valid or not, but an avenue to consider.

@jcfilben jcfilben added the design label Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants