-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Tag to use Close icon #363
Comments
Greg chose the FormClose icon when he originally designed the Tag partly for this reason. Why do we currently feel it should be the bigger icon? Affecting the height of the Tag will cause alot of problems. |
I think the desire is for the HPE theme to no longer use the 'Form' icons. But agree this causes issues with Tag. Seems like we need to have more design discussion here before moving forward with this. |
Or, theme does something like
Don't know if that is valid or not, but an avenue to consider. |
This ticket must wait until grommet/grommet#6870 is merged. Update Tag icon to use
Close
as opposed toFormClose
.The text was updated successfully, but these errors were encountered: