Use Brand Central font versions #288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
halocline
reviewed
Oct 28, 2022
|
Interestingly it seems like that CDN has Metric-Regular, -Light, -Semibold but is missing -Medium and -Bold. |
I think we should at least try to have a conversation with the team managing. Let's do that and evaluate from there. |
halocline
reviewed
Nov 23, 2022
ericsoderberghp
approved these changes
Feb 1, 2023
halocline
approved these changes
Feb 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Based on outcomes of grommet/hpe-design-system#2990, reverting the theme to point to brand central font version. The URLs were provided by Artur's team. I had to explicitly define regular as font-weight 400 otherwise it wasn't applying it.
What testing has been done on this PR?
Tested locally in the site on Mac Chrome, Windows Edge:
Mac Chrome:
New font, Windows Edge (notice how the "i" is differentiable from "l", j has a visibly separate dot)
Old font (on Windows, i is not differentiable from l at certain sizes/weights)
Any background context you want to provide?
What are the relevant issues?
Closes grommet/hpe-design-system#2990
Screenshots (if appropriate)
Is this change backward compatible or could it be a breaking change for the official HPE theme?
How should this PR be communicated in the release notes?