Update tag.mdx #4079
Merged
Update tag.mdx #4079
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Transferring content from Figma to Tag page. Edits still coming.
Closed
10 tasks
|
Hey Brittany - |
Closed
10 tasks
|
In order to have the type highlight we need to make an enhancement to grommet |
vavalos5
commented
Sep 23, 2024
vavalos5
commented
Sep 23, 2024
vavalos5
commented
Sep 23, 2024
taysea
reviewed
Sep 26, 2024
taysea
reviewed
Sep 26, 2024
taysea
reviewed
Sep 26, 2024
taysea
reviewed
Sep 26, 2024
| > | ||
| <CreateTagSimple /> | ||
| </Example> | ||
| ### Tag |
There was a problem hiding this comment.
Seems like this should just be "Static", Tag is the thing and static is the type. Then the other types build off of static.
If so, rename this to "Static" and remove the current section called "Static".
taysea
reviewed
Sep 26, 2024
taysea
reviewed
Sep 26, 2024
taysea
reviewed
Sep 26, 2024
taysea
reviewed
Sep 26, 2024
taysea
reviewed
Sep 26, 2024
taysea
reviewed
Sep 26, 2024
taysea
reviewed
Sep 26, 2024
Co-authored-by: Taylor Seamans <[email protected]>
Co-authored-by: Taylor Seamans <[email protected]>
Co-authored-by: Taylor Seamans <[email protected]>
Co-authored-by: Taylor Seamans <[email protected]>
Co-authored-by: Taylor Seamans <[email protected]>
Co-authored-by: Taylor Seamans <[email protected]>
Co-authored-by: Taylor Seamans <[email protected]>
Co-authored-by: Taylor Seamans <[email protected]>
vavalos5
commented
Oct 2, 2024
| - Draws attention but is no louder than a secondary/primary button. | ||
| - A highlight tag is not interactive in any way. | ||
| - A tags size should be limited to x-small or small. | ||
| - Use “blue!” border for highlight tags. This treatment should be used sparingly. |
|
|
||
| ## Assigning tags | ||
| <Example plain> |
There was a problem hiding this comment.
All the types should have value styling to them. So the medium font-weight.
|
Once #4230 merges in here, I am happy for this PR to be merged in. Nice work! |
Tag -- Lint fixes and adjust example
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Transferring content from Figma to Tag page. Edits still coming.
Deploy Preview
What does this PR do?
Where should the reviewer start?
What testing has been done on this PR?
In addition to the feature you are implementing, have you checked the following:
General UX Checks
Accessibility Checks
Code Quality Checks
How should this be manually tested?
Any background context you want to provide?
What are the relevant issues?
Screenshots (if appropriate)
Should this PR be mentioned in Design System updates?
Is this change backwards compatible or is it a breaking change?