Add Select clear selection example #4231
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deploy Preview
What does this PR do?
Adds example to the site with "Clear selection". This requires grommet/grommet-theme-hpe#412 to be released before merging.
NOTE: Right now in Grommet if a
name
is passed to Select, that's used to in place of the word "selection" in "Clear selection" button. This just felt a little odd because name is usually more "dev centric" wording than user facing. For now, I've implemented by passing an object to define my own label likeclear={{ label: 'Clear selection' }}
-- in terms of being able to standardize wording though it does feel a bit off.Where should the reviewer start?
What testing has been done on this PR?
In addition to the feature you are implementing, have you checked the following:
General UX Checks
Accessibility Checks
Code Quality Checks
How should this be manually tested?
Any background context you want to provide?
What are the relevant issues?
Closes #4225
Screenshots (if appropriate)
Should this PR be mentioned in Design System updates?
Is this change backwards compatible or is it a breaking change?