ci: Change to login and push only when push is needed #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Failure of CI is resolved by #15. |
komainu8
reviewed
Dec 6, 2024
.github/workflows/build.yml
Outdated
| if [ "${GITHUB_EVENT_NAME}" = "push" ]; then | ||
| need_push="yes" | ||
| if [ "${GITHUB_REF_TYPE}" = "tag" ] && [ "${version}" != "${GITHUB_REF_NAME}" ]; then | ||
| need_push="no" |
There was a problem hiding this comment.
"${GITHUB_REF_TYPE}" = "tag"の時はneed_push="yes"ではないでしょうか？
"${GITHUB_REF_TYPE}" = "tag"が成立するのは、tagをpushした場合だと思うのですが、tagをpushした時は、
DockerイメージもDocker Hub( https://hub.docker.com/r/groonga/groonga )へプッシュされてほしいと思うので。
There was a problem hiding this comment.
mroonga/docker から頂戴してきたやつでした。
https://github.com/mroonga/docker/blob/edbf49485c774b817e73c0214b55cbeb040f534d/.github/workflows/build.yml#L26-L38
mroonga/docker の場合はtagプッシュがあっても、タグの種類でDockerイメージをプッシュしたくないときがあったので付けていた条件です。
が、こちらでは不要なので削除しました。
komainu8
approved these changes
Dec 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.