-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
news: add 1.0.1 entry #25
Conversation
NEWS.md
Outdated
In previous releases, Ubuntu packages were available only through the Groonga | ||
APT repository. Starting with this release, packages are also distributed via | ||
packages.groonga.org. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the difference between "the Groonga APT repository" and "package.groonga.org"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fix: 9dd1041 I added the difference about the dependency package.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does "the Groonga APT repository" mean https://launchpad.net/~groonga/+archive/ubuntu/ppa ?
We should call it as "the Groonga APT repository". We should call https://packages.groonga.org/ as "the Groonga APT repository" because packages.groonga.org is managed by us.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fix: f24f394 I see. So both of them are "the Groonga APT repository".
I tried to rewrite it using specified url. What do you think of it? Or should I call the other ways?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, sorry.
We should call it as "the Groonga APT repository".
↓
We should NOT call it as "the Groonga APT repository".
Thanks you for reviewing. I fixed what you pointed out 🙏🏾 |
NEWS.md
Outdated
built with Apache Arrow enabled. Which unlocks extra features such as static | ||
parallel index building. | ||
|
||
### Migration Notice for groonga-nginx |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Migration should only be required for Ubuntu users, so it is better to add that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fix: dbc6986
NEWS.md
Outdated
|
||
While the groonga-nginx package itself remains unchanged, the underlying Groonga | ||
dependency is different. The packages from packages.groonga.org include Groonga | ||
built with Apache Arrow enabled. Which unlocks extra features such as static |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
built with Apache Arrow enabled. Which unlocks extra features such as static | |
built with Apache Arrow enabled. Which unlocks extra features such as offline |
https://groonga.org/docs/reference/indexing.html#offline-index-construction
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fix: ad73c68
$ sudo apt install -y -V ./groonga-apt-source-latest-$(lsb_release --codename --short).deb | ||
$ rm -f groonga-apt-source-latest-$(lsb_release --codename --short).deb | ||
$ sudo apt update | ||
$ sudo apt install -y -V libnginx-mod-http-groonga |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ppaからインストールした libgroonga0
とかが残っていても大丈夫ですか?
libnginx-mod-http-groonga
はまだ packages.groonga.org にないですが、これで移行できるかどのように確認しました?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
現状確認できないので、リリースしてから確認するしかないのかなぁと考えていました。
ここには詳細を書かないで、README.mdを見てねと促して、あとから確認できた手段を明記したほうが良さそうですかねmm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
不確定な情報を記載するよりは、確実な情報を記載したほうが良いので、移行方法はあとからREADMEとかに書くほうが良かろうと思います。
(MIGRATION.md とか別ファイルを作っても良さそうです。)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Groongaの方に書いてそっちを参照でもいいかも。
Groongaの方はもうリリース済みだから動作確認できるよね?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
一旦、ここまでで作業を止めてGroonga側に移行方法のドキュメントを書こうと思います。
Thanks you for reviewing. I fixed what you pointed out 🙏🏾 |
NEWS.md
Outdated
### Package distribution update | ||
|
||
In previous releases, Ubuntu packages were available only through | ||
https://launchpad.net/~groonga/+archive/ubuntu/ppa. Starting with this release, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://groonga.org/docs/install/ubuntu.html#ppa-personal-package-archive said "PPA on Launchpad". In general, users don't see https://launchpad.net/~groonga/+archive/ubuntu/ppa URL when they use. Because they use add-apt-repository ppa:groonga/ppa
.
BTW, it said that "The Groonga APT repository for Ubuntu"...
Working on #26. |
No description provided.