ci: Build the documents #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prepare to deploy documents automatically with CI. First, we set up CI to build the document.
kou
reviewed
Nov 7, 2024
.github/workflows/publish.yml
Outdated
.github/workflows/publish.yml
Outdated
| - name: Build documents | ||
| run: | | ||
| cmake -S groonga -B /tmp/groonga.build --preset=doc | ||
| (cd groonga && rake release:document:update BUILD_DIR=/tmp/groonga.build GROONGA_ORG_DIR=../) |
There was a problem hiding this comment.
Suggested change
| (cd groonga && rake release:document:update BUILD_DIR=/tmp/groonga.build GROONGA_ORG_DIR=../) | |
| rake -C groonga release:document:update BUILD_DIR=/tmp/groonga.build GROONGA_ORG_DIR=../ |
There was a problem hiding this comment.
make なやつだから -C 使えたんか。
komainu8
reviewed
Nov 7, 2024
.github/workflows/publish.yml
Outdated
| on: | ||
| push: | ||
| branches: | ||
| - main |
There was a problem hiding this comment.
Suggested change
| - main | |
| - gh-pages |
kou
reviewed
Nov 7, 2024
.github/workflows/document.yml
Outdated
| @@ -0,0 +1,34 @@ | |||
| name: Publish | |||
There was a problem hiding this comment.
Suggested change
| name: Publish | |
| name: Document |
.github/workflows/document.yml
Outdated
Comment on lines
12
to
13
| build: | ||
| name: Build and Publish |
There was a problem hiding this comment.
Suggested change
| build: | |
| name: Build and Publish | |
| publish: | |
| name: Publish |
.github/workflows/document.yml
Outdated
| groonga/setup.sh | ||
| pip install -r groonga/doc/requirements.txt | ||
| (cd groonga/doc && bundle install) | ||
| - name: Build documents |
There was a problem hiding this comment.
英語圏の人たちはdocumentsと言っているような気はするし、groonga.org/docs/だけど、他のところでdocにしちゃったんだよなぁ。どっちに合わせるのがいいかしら。
Suggested change
| - name: Build documents | |
| - name: Build document |
There was a problem hiding this comment.
省略しないやつはあまり気にしたことがなかったですが、省略形は docs が多い感じがします。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prepare to deploy documents automatically with CI.
First, we set up CI to build the document.