refs #139: run database down scenarios in a separated file

groot-mg · Nov 3, 2023 · e73551b · e73551b
1 parent c868cdd
commit e73551b
Show file tree

Hide file tree

Showing 5 changed files with 40 additions and 35 deletions.
diff --git a/sales-catalog-ft/src/test/kotlin/com/generoso/ft/salescatalog/utils/PostgresDao.kt b/sales-catalog-ft/src/test/kotlin/com/generoso/ft/salescatalog/utils/PostgresDao.kt
@@ -5,6 +5,7 @@ import io.zonky.test.db.postgres.embedded.EmbeddedPostgres
 import org.postgresql.util.PSQLException
 import org.slf4j.LoggerFactory
 import org.springframework.stereotype.Component
+import java.sql.DriverManager
 import java.sql.SQLException
 import java.sql.Timestamp
 import java.util.*
@@ -21,6 +22,9 @@ class PostgresDao(
             embeddedPostgres.postgresDatabase.connection
         } catch (ex: PSQLException) {
             embeddedPostgres = EmbeddedPostgres.builder().setPort(5432).start()
+            while(DriverManager.getConnection(embeddedPostgres.getJdbcUrl("postgres", "postgres")) == null) {
+                Thread.sleep(1000)
+            }
         }
         createTables()
     }

diff --git a/sales-catalog-ft/src/test/resources/features/actuator.feature b/sales-catalog-ft/src/test/resources/features/actuator.feature
@@ -11,15 +11,6 @@ Feature: Checking Service Discovery actuator endpoints return expected outputs
       | ping               |
       | refreshScope       |
 
-  Scenario: When database is down, returns 503 response status
-    Given a private endpoint PRIVATE_HEALTH_CHECK is prepared
-    And database is down
-    When the request is sent
-    Then the response status code should be 503
-    And the health response body of the message should have the status "DOWN"
-    And health components should contain the status DOWN:
-      | db                 |
-
   Scenario: When application is running, display metric content
     Given a private endpoint PRIVATE_METRICS is prepared
     When the request is sent

diff --git a/sales-catalog-ft/src/test/resources/features/database.feature b/sales-catalog-ft/src/test/resources/features/database.feature
@@ -0,0 +1,34 @@
+Feature: Scenarios for database down
+
+  Background:
+    And database is down
+
+  # Actuator
+  Scenario: When database is down, returns 503 response status
+    Given a private endpoint PRIVATE_HEALTH_CHECK is prepared
+    When the request is sent
+    Then the response status code should be 503
+    And the health response body of the message should have the status "DOWN"
+    And health components should contain the status DOWN:
+      | db |
+
+  # Get products
+  Scenario: When call to retrieve products and database is down should return 500
+    Given an endpoint PRODUCT_GET is prepared
+    When the request is sent
+    Then the response status code should be 500
+    And the response error detail should be Database exception
+
+  Scenario: When call to retrieve product by id gets a database down should return 500
+    Given an endpoint PRODUCT_GET is prepared with path parameter d6b76b42-7a45-11ee-b962-0242ac120002
+    When the request is sent
+    Then the response status code should be 500
+    And the response error detail should be Database exception
+
+  # Create products
+  Scenario: When a sales user calls to register a new product and database is down should return internal server error
+    Given an endpoint PRODUCT_POST is prepared
+    And use a JWT token for user sales with role api-sales
+    When the request is sent
+    Then the response status code should be 500
+    And the response error detail should be Database exception
diff --git a/sales-catalog-ft/src/test/resources/features/product/product_create.feature b/sales-catalog-ft/src/test/resources/features/product/product_create.feature
@@ -74,13 +74,4 @@ Feature: Product controller scenarios for creating a new product
       | DESCRIPTION_MISSING              |
       | PRICE_MAX_DIGITS_ALLOWED         |
       | PRICE_DECIMAL_MAX_DIGITS_ALLOWED |
-      | QUANTITY_POSITIVE                |
-
-  # Internal Server Error
-  Scenario: When a sales user calls to register a new product and database is down should return internal server error
-    Given an endpoint PRODUCT_POST is prepared
-    And use a JWT token for user sales with role api-sales
-    And database is down
-    When the request is sent
-    Then the response status code should be 500
-    And the response error detail should be Database exception
+      | QUANTITY_POSITIVE                |
diff --git a/sales-catalog-ft/src/test/resources/features/product/products_get.feature b/sales-catalog-ft/src/test/resources/features/product/products_get.feature
@@ -183,19 +183,4 @@ Feature: Product controller scenarios for retrieving products
     Then the response status code should be 200
     And product response object has:
       | version | name         | description         | price | quantity | isReserved | isSold |
-      | v1      | Product name | Product description | 10.00 | 50       | false      | false  |
-
-  # Internal Server Error
-  Scenario: When call to retrieve products and database is down should return 500
-    Given an endpoint PRODUCT_GET is prepared
-    And database is down
-    When the request is sent
-    Then the response status code should be 500
-    And the response error detail should be Database exception
-
-  Scenario: When call to retrieve product by id gets a database down should return 500
-    Given an endpoint PRODUCT_GET is prepared with path parameter d6b76b42-7a45-11ee-b962-0242ac120002
-    And database is down
-    When the request is sent
-    Then the response status code should be 500
-    And the response error detail should be Database exception
+      | v1      | Product name | Product description | 10.00 | 50       | false      | false  |