Mark mutable strings as mutable #142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Running the test suite with RUBYOPT="--enable-frozen-string-literal" simulates Ruby's future behavior having frozen string on by default. This fixed the error that happens with this option enabled by marking two strings which are mutated as mutable with the + operator.
|
ahh 🤦 this is wrong ... they are consts and should already be frozen |
|
bug is that - lib/fast_gettext/vendor/**/* is excluded from rubocop :/ |
|
... let's at least run CI with frozen strings so this does not happen again #143 |
|
3.1.0 |
|
Thanks! ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Running the test suite with RUBYOPT="--enable-frozen-string-literal" simulates Ruby's future behavior having frozen string on by default. This fixed the error that happens with this option enabled by marking two strings which are mutated as mutable with the
+operator.