-
Notifications
You must be signed in to change notification settings - Fork 821
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Actuator healthcheck #1103
base: master
Are you sure you want to change the base?
Actuator healthcheck #1103
Conversation
337738f
to
b5975ea
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm currently buzy with work, so reviews will take a while.
grpc-server-spring-boot-starter/src/main/java/net/devh/boot/grpc/server/config/HealthType.java
Outdated
Show resolved
Hide resolved
...r-spring-boot-starter/src/main/java/net/devh/boot/grpc/server/health/ActuatorGrpcHealth.java
Outdated
Show resolved
Hide resolved
...r-spring-boot-starter/src/main/java/net/devh/boot/grpc/server/health/ActuatorGrpcHealth.java
Outdated
Show resolved
Hide resolved
grpc-server-spring-boot-starter/src/main/java/net/devh/boot/grpc/server/config/HealthType.java
Outdated
Show resolved
Hide resolved
...spring-boot-starter/src/main/java/net/devh/boot/grpc/server/config/GrpcServerProperties.java
Show resolved
Hide resolved
...spring-boot-starter/src/main/java/net/devh/boot/grpc/server/config/GrpcServerProperties.java
Outdated
Show resolved
Hide resolved
.../net/devh/boot/grpc/server/autoconfigure/GrpcHealthServiceTrueActuatorConfigurationTest.java
Show resolved
Hide resolved
...ring-boot-starter/src/test/java/net/devh/boot/grpc/server/health/ActuatorGrpcHealthTest.java
Show resolved
Hide resolved
...r-spring-boot-starter/src/main/java/net/devh/boot/grpc/server/health/ActuatorGrpcHealth.java
Outdated
Show resolved
Hide resolved
Co-authored-by: ST-DDT <[email protected]>
Co-authored-by: ST-DDT <[email protected]>
Co-authored-by: ST-DDT <[email protected]>
…pc/server/autoconfigure/GrpcHealthServiceTrueActuatorConfigurationTest.java Co-authored-by: ST-DDT <[email protected]>
…pc/server/health/ActuatorGrpcHealthTest.java Co-authored-by: ST-DDT <[email protected]>
459c018
to
dc3e521
Compare
dc3e521
to
183c22b
Compare
fd3070e
to
259cec4
Compare
259cec4
to
65e8a1b
Compare
Hi @ST-DDT, thanks for the review. I think all your comments have been addressed. Let me know if you see more improvements for this feature. About the watch method, I didn't start it yet, but I was thinking in doing it in a separate PR because I think it will involve a lot more code, or do you prefer to have everything here in this pr? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, for the delay in the reviews. I haven't tested it yet, but looks good to me.
Hey @ST-DDT , thanks for your review. |
Sorry for the delay. |
Hello @ST-DDT do you know if this pr is blocked for some reason or can I contact some maintainers to help with it, I'm facing a similar situation and having this in the main branch will be good |
@yidongnan Who is currently maintaining this project? |
This is the initial work for #1091.
It is only implementing the
check
now, but watch will be added later by pushing metrics every 30s as @ST-DDT suggested.I was wondering if this should be the default behavior when the actuator is present, so I added a property to enable this instead of the GRPC standard health endpoint.