fix: changes grpc server exception handler order #1134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/review @ST-DDT |
ST-DDT
requested changes
Aug 16, 2024
Comment on lines
+107
to
+109
| public void error(Empty request, StreamObserver<Empty> responseObserver) { | ||
| throw new RuntimeException("a simulated error"); | ||
| } |
There was a problem hiding this comment.
Please also add a streaming variant of this test.
Also I'm thinking of whether we should have an additional test for responseObserver.onError(exception) in addition to just throwing inside the method.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the
GrpcExceptionInterceptorbean after theObservationGrpcServerInterceptorand theMetricCollectingServerInterceptorand before theExceptionTranslatingServerInterceptor.This is necessary in order to allow the later interceptor to process the error response after the exception handler is executed, more precisely to add the returned
status codeto the context/meter.Im not entirely sure but i believe this was an unintentional consequence of the added support for Order because the GrpcAdviceAutoConfiguration already had the
@Orderwith the 0 precedence it was just not doing anything.fixes #789 #1088