update deps; simplify analysis options #790
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
devoncarew
commented
Jun 9, 2025
devoncarew
commented
- require Dart 3.6
- update deps for the example packages
- simplify analysis options for the example packages
PR Health
Breaking changes
|
| Package | Change | Current Version | New Version | Needed Version | Looking good? |
|---|---|---|---|---|---|
| grpc | Breaking | 4.1.0 | 4.1.1-wip | 5.0.0 Got "4.1.1-wip" expected >= "5.0.0" (breaking changes) |
This check can be disabled by tagging the PR with skip-breaking-check.
Changelog Entry ✔️
| Package | Changed Files |
|---|
Changes to files need to be accounted for in their respective changelogs.
API leaks ⚠️
The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.
| Package | Leaked API symbols |
|---|---|
| grpc | Any $1.Duration |
This check can be disabled by tagging the PR with skip-leaking-check.
mosuem
approved these changes
Jun 11, 2025
mosuem
reviewed
Jun 11, 2025
pubspec.yaml
Outdated
| @@ -9,24 +9,24 @@ topics: | |||
| - rpc | |||
|
|
|||
| environment: | |||
| sdk: ^3.5.0 | |||
| sdk: ^3.6.0 | |||
There was a problem hiding this comment.
We could go to 3.8.0 as the current stable is beyond that.. And then run a dart pub upgrade --tighten, as the lowest bounds don't build for me locally.
mosuem
approved these changes
Jun 11, 2025
|
FYI, moving to 3.8 required a full dart format of all dart source files. |
|
(fyi that I can't land PRs here) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.