-
Notifications
You must be signed in to change notification settings - Fork 4.5k
[interop client] provide a flag to set google-c2p resolver universe domain #8145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8145 +/- ##
==========================================
+ Coverage 82.39% 82.43% +0.04%
==========================================
Files 389 389
Lines 39125 39125
==========================================
+ Hits 32238 32254 +16
+ Misses 5568 5556 -12
+ Partials 1319 1315 -4 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I think we should wait for grpc/grpc#38933 to be merged before merging this to ensure the flag name and behaviour are finalized.
@apolcyn : Are we still waiting on grpc/grpc#38933, or should we close this? |
Lost track of grpc/grpc#38933, we still want this though |
Documentation PR: grpc/grpc#38933
RELEASE NOTES: N/A