xds/internal:remove Generic resource Decoder and added concrete functions #8381 #8582
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #8582 +/- ##
==========================================
+ Coverage 81.98% 82.00% +0.02%
==========================================
Files 413 415 +2
Lines 40528 40738 +210
==========================================
+ Hits 33225 33407 +182
+ Misses 5944 5934 -10
- Partials 1359 1397 +38
🚀 New features to boost your workflow:
|
vinothkumarr227
changed the title
eshitachandwani
added
Type: Internal Cleanup
|
@vinothkumarr227 , can you please break this PR down into smaller PRs with one resource in one PR so that it is easier to understand and review. |
|
|
||
| // LoadStore is the minimal interface returned by ReportLoad. It provides a | ||
| // way to get per-cluster reporters and to stop the store. | ||
| type LoadStore interface { |
There was a problem hiding this comment.
Why did we add this interface?
| // balancer when LRS is enabled. Before that, all functions to record loads | ||
| // are no-op. | ||
| store *lrsclient.LoadStore | ||
| perCluster *lrsclient.PerClusterReporter |
There was a problem hiding this comment.
Why did we change it to use the grpc xdsclient interfaces that we created?
| // are are deserialized and validated, as received from the xDS management | ||
| // server. Upon receipt of a response from the management server, an | ||
| // appropriate callback on the watcher is invoked. | ||
| func (c *clientImpl) WatchResource(rType xdsresource.Type, resourceName string, watcher xdsresource.ResourceWatcher) (cancel func()) { |
There was a problem hiding this comment.
If we are changing the type parameter, can we change it to a string so that the signatures match and we can directly call the xdsclient.WatchResource?
| // interface with ref counting so that it can be shared by the xds resolver and | ||
| // balancer implementations, across multiple ClientConns and Servers. | ||
| type clientImpl struct { | ||
| *xdsclient.XDSClient // TODO: #8313 - get rid of embedding, if possible. |
There was a problem hiding this comment.
Why did we make this change?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #8381
RELEASE NOTES: