Skip to content

Commit

Permalink
Avoid interop build instructions when already built
Browse files Browse the repository at this point in the history
This reduces the amount of logspam generated during interop testing.
Telling someone how to build when they have already obviously built
doesn't serve much purpose, now that everyone is used to it not
building automatically.
  • Loading branch information
ejona86 committed Oct 12, 2018
1 parent 5362017 commit fab303b
Show file tree
Hide file tree
Showing 2 changed files with 16 additions and 12 deletions.
14 changes: 8 additions & 6 deletions run-test-client.sh
Original file line number Diff line number Diff line change
@@ -1,9 +1,11 @@
#!/bin/bash -e
cd "$(dirname "$0")"
cat >&2 <<EOF
Gradle is no longer run automatically. Make sure to run
'./gradlew installDist -PskipCodegen=true' or
'./gradlew :grpc-interop-testing:installDist -PskipCodegen=true' after any
changes. -PskipCodegen=true is optional, but requires less setup.
BIN="./interop-testing/build/install/grpc-interop-testing/bin/test-client"
if [[ ! -e "$BIN" ]]; then
cat >&2 <<EOF
Could not find binary. It can be built with:
./gradlew :grpc-interop-testing:installDist -PskipCodegen=true
EOF
exec ./interop-testing/build/install/grpc-interop-testing/bin/test-client "$@"
exit 1
fi
exec "$BIN" "$@"
14 changes: 8 additions & 6 deletions run-test-server.sh
Original file line number Diff line number Diff line change
@@ -1,9 +1,11 @@
#!/bin/bash -e
cd "$(dirname "$0")"
cat >&2 <<EOF
Gradle is no longer run automatically. Make sure to run
'./gradlew installDist -PskipCodegen=true' or
'./gradlew :grpc-interop-testing:installDist -PskipCodegen=true' after any
changes. -PskipCodegen=true is optional, but requires less setup.
BIN="./interop-testing/build/install/grpc-interop-testing/bin/test-server"
if [[ ! -e "$BIN" ]]; then
cat >&2 <<EOF
Could not find binary. It can be built with:
./gradlew :grpc-interop-testing:installDist -PskipCodegen=true
EOF
exec ./interop-testing/build/install/grpc-interop-testing/bin/test-server "$@"
exit 1
fi
exec "$BIN" "$@"

0 comments on commit fab303b

Please sign in to comment.