Examples: Updated HelloWorldServer to use Executor #11850
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shivaspeaks
added
the
kokoro:run
grpc-kokoro
removed
the
kokoro:run
examples/src/main/java/io/grpc/examples/helloworld/HelloWorldServer.java
Outdated
Show resolved
Hide resolved
examples/src/main/java/io/grpc/examples/helloworld/HelloWorldServer.java
Outdated
Show resolved
Hide resolved
larry-safran
approved these changes
Feb 4, 2025
larry-safran
added
the
kokoro:run
grpc-kokoro
removed
the
kokoro:run
shivaspeaks
reviewed
Feb 5, 2025
There was a problem hiding this comment.
Is this the problem only with this example or do we need changes in other examples as well?
cc: @larry-safran
|
Only update this one example. The executor is not required so we want
examples both with and without it.
…On Tue, Feb 4, 2025 at 11:31 PM MV Shiva ***@***.***> wrote:
***@***.**** commented on this pull request.
Is this the problem only with this example or do we need changes in other
examples as well? @larry-safran <https://github.com/larry-safran>
—
Reply to this email directly, view it on GitHub
<#11850 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AZQMCXRIVTPC4PY7NQY3JQL2OG44TAVCNFSM6AAAAABVW7NJC2VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDKOJUHAZTQNRUGM>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
ejona86
reviewed
Feb 5, 2025
examples/src/main/java/io/grpc/examples/helloworld/HelloWorldServer.java
Outdated
Show resolved
Hide resolved
examples/src/main/java/io/grpc/examples/helloworld/HelloWorldServer.java
Outdated
Show resolved
Hide resolved
vinodhabib
reviewed
Feb 10, 2025
examples/src/main/java/io/grpc/examples/helloworld/HelloWorldServer.java
Outdated
Show resolved
Hide resolved
larry-safran
approved these changes
Feb 10, 2025
shivaspeaks
added
the
kokoro:run
grpc-kokoro
removed
the
kokoro:run
shivaspeaks
approved these changes
Feb 12, 2025
shivaspeaks
reviewed
Feb 12, 2025
| @@ -20,9 +20,12 @@ | |||
| import io.grpc.InsecureServerCredentials; | |||
| import io.grpc.Server; | |||
| import io.grpc.stub.StreamObserver; | |||
| import io.grpc.ServerBuilder; | |||
There was a problem hiding this comment.
I don't see this getting used anywhere! Remove this import.
I wonder how it is making this far by clearing all the github tests. It should already be failing in checkstyle saying unused import or something!!! @ejona86
There was a problem hiding this comment.
Fixed, In local build as well as in the PR check, I don't see any issues related to the same
shivaspeaks
added
the
kokoro:run
grpc-kokoro
removed
kokoro:run
shivaspeaks
approved these changes
Feb 18, 2025
shivaspeaks
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #2263