Skip to content

feat(api): adds new channel builder with name resolver registry and provider #11978

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

feat(api): adds new channel builder with name resolver registry and provider #11978

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5a5bc46
feat(api): adds new channel builder with name resolver registry and p…
AgraVator Mar 25, 2025
8cb30b3
fix: exposes a new ManagedChannelProvider.newChannelBuilder with Name…
AgraVator Mar 25, 2025
ae5c4a9
style: fixes checkstyle
AgraVator Mar 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions api/src/main/java/io/grpc/ManagedChannelProvider.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,17 @@
return NewChannelBuilderResult.error("ChannelCredentials are unsupported");
}

/**
* Creates a channel builder with a target string, credentials, NameResolverRegistry
* and NameResolverProvider. Returns an error-string result if unable to
* understand the credentials.
*/
protected NewChannelBuilderResult newChannelBuilder(String target, ChannelCredentials creds,
NameResolverRegistry nameResolverRegistry,
NameResolverProvider nameResolverProvider) {
return newChannelBuilder(target, creds);

Check warning on line 92 in api/src/main/java/io/grpc/ManagedChannelProvider.java

View check run for this annotation

Codecov / codecov/patch

api/src/main/java/io/grpc/ManagedChannelProvider.java#L92 

Added line #L92 was not covered by tests
}

/**
* Returns the {@link SocketAddress} types this ManagedChannelProvider supports.
*/
Expand Down