Android: Clean up lint warnings and other warnings to get build success #12143
Conversation
|
@ejona86 @shivaspeaks Can you please review. |
|
@Sangamesh1997 Can you provide the build error log that you are fixing with this PR? In the failing build.log of PR #12040 I don't see any errors about @TargetApi for example. |
shivaspeaks
added
the
kokoro:run
grpc-kokoro
removed
the
kokoro:run
|
@kannanjgithub In the build log of PR #12040 , I observed that the only visible lint error was OldTargetApi. However, when I ran the lint check locally in (lint report.html), it also flagged other warnings like InlineApi, ObseleteSdkInt and NewApi, as mentioned by Eric earlier. So in this PR, I've fixed all these together to ensure build passes cleanly and is future-proof. |
|
@Sangamesh1997 can you share that lint report.html? |
There was a problem hiding this comment.
Are we working on silencing? I thought the discussion happened to upgrade and fix in the #12040 (comment)
@shivaspeaks I have addressed and cleared all the lint warnings in #12143, which resolves the issue tracked in #6868. |
shivaspeaks
added
the
kokoro:run
grpc-kokoro
removed
the
kokoro:run
Does it cause any problem if you set targetSdkVersion to the latest available even while the AGP is not upgraded yet? @Sangamesh1997 |
| @@ -165,6 +166,7 @@ public Intent asBindIntent() { | |||
| * | |||
| * <p>See {@link Intent#URI_ANDROID_APP_SCHEME} for details. | |||
| */ | |||
| @SuppressLint("InlinedApi") | |||
There was a problem hiding this comment.
The warning inlinedApi is about using the constant URI_ANDROID_APP_SCHEME that was introduced in API level 22. Instead do intentForUri.toUri(android.os.Build.VERSION.SDK_INT < 22? URL_INTENT_SCHEME : URI_ANDROID_APP_SCHEME);
and remove the suppression. If the linter still complains, then add @TargetApi(22) to indicate that we are only using URI_ANDROID_APP_SCHEME at and above API level 22.
There was a problem hiding this comment.
@kannanjgithub yes fixed with conditional version check only - lint warnings resolved without @TargetApi working.
| @@ -183,18 +184,22 @@ private static Status bindInternal( | |||
| bindResult = context.bindService(bindIntent, conn, flags); | |||
| break; | |||
| case BIND_SERVICE_AS_USER: | |||
| bindResult = context.bindServiceAsUser(bindIntent, conn, flags, targetUserHandle); | |||
| if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.R) { | |||
There was a problem hiding this comment.
It is going to fail the connection with Unimplemented for Android API levels 21 - 29. It would already be crashing for these API levels? @ejona86 . Also for similar changes below.
| @@ -0,0 +1,4 @@ | |||
| <?xml version="1.0" encoding="UTF-8"?> | |||
| <lint> | |||
| <issue id="OldTargetApi" severity="ignore" /> | |||
There was a problem hiding this comment.
Does it cause any problem if you set targetSdkVersion to the latest available even while the AGP is not upgraded yet?
There was a problem hiding this comment.
Yes, it causes AAPT2 linking failures due to resource format changes. AGP 7.x is incompatible with SDK 35/36, so AGP must be upgraded first. keeping the lint.xml suppression after upgrading AGP/SDK won’t break anything, and have to remove it after the AGP/SDK upgrade to keep our configuration clean.
Sangamesh1997
force-pushed
the
Issue_fixed_12142
branch
from
37f84d1 to
94532a6
Compare
…xed_12142 # Conflicts: # binder/src/main/java/io/grpc/binder/internal/ServiceBinding.java
@kannanjgithub I tried and got a build failure with 'AAPT2 error: Android resourse linking failed'. SDK 35/36 introduced internal changes in resource formats. The current AGP versions cant handle these changes during resource linking. that's why I suspect that using compileSdk>34 is unsafe unless AGP is upgraded to 8.x.+. |
Fixes : #6868 #12142
Worked on clearing the lint warnings (OldTargetApi, ObsoleteSdkInt, InlinedApi, NewApi)