Skip to content

java_grpc_library.bzl: Make warnings less noisy #12195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mkosiba
Copy link

@mkosiba mkosiba commented Jun 30, 2025

This is to partially address #11791.
The idea is to only inform the user if one of labels are in the root repository and therefore under the user's control.

This is to partially address grpc#11791.
The idea is to only inform the user if one of labels are in the root
repository and therefore under the user's control.
Copy link

CLA Not Signed

@ejona86
Copy link
Member

ejona86 commented Jul 2, 2025

I'm not aware of any Bazel tooling that only reports warnings when it is under the user's control. Are you?

@mkosiba
Copy link
Author

mkosiba commented Jul 3, 2025

I'm not aware of any Bazel tooling that only reports warnings when it is under the user's control. Are you?

Plenty of tooling behaves this way:

  • bazel coverage won't cover stuff in external/ (which is usually 3rd party code) by default,
  • most linters and static code analysis behave this way (say, for Java your linters won't tell you about potential issues inside of the jars you're compiling against).

I can narrow this down to just grpc-java and grpc-proto if that's somehow better. Either way I think it's counter-productive to keep a warning that's "unfortunately expected" (as per referenced issue). At work at I've got internal users occasionally pinging me about this, trying to figure out if they're importing the wrong versions of deps or whatever, so this is affecting real users.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants