xds: Do RLS fallback policy eagar start #12211
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ngRlsLbClient, there is a need to call deliveryResolvedAddress() inside synch context, that eventually calls acceptResolvedAdddresses for the fallback policy wrapper.
ejona86
approved these changes
Jul 11, 2025
| // TODO(creamsoup) wait until lb is ready | ||
| String defaultTarget = lbPolicyConfig.getRouteLookupConfig().defaultTarget(); | ||
| if (defaultTarget != null && !defaultTarget.isEmpty()) { | ||
| logger.log(ChannelLogLevel.DEBUG, "starting fallback to {0}", defaultTarget); |
| @@ -700,6 +705,7 @@ public void metricGauges() throws ExecutionException, InterruptedException, Time | |||
| // Shutdown | |||
| rlsLbClient.close(); | |||
| verify(mockGaugeRegistration).close(); | |||
| isAlreadyClosed = true; | |||
There was a problem hiding this comment.
FWIW, a pattern we use in other tests is to do rlsLbClient = null and then null-check in @After.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starts the fallback LB policy for the default target at the start of RLS policy instead of only when falling back to the default target.