Skip to content

xds: Check isHttp11ProxyAvailable in equals() #12212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

xds: Check isHttp11ProxyAvailable in equals() #12212

wants to merge 1 commit into from
+26 −2

Conversation

ejona86
Copy link
Member

@ejona86 ejona86 commented Jul 11, 2025

This fixes an equals/hashCode bug introduced in 1219706.

Discovered when investigating b/430347751

CC @kannanjgithub

@ejona86
xds: Check isHttp11ProxyAvailable in equals()
5ec7fbd 
This fixes an equals/hashCode bug introduced in 1219706.

Discovered when investigating b/430347751
@ejona86 ejona86 requested a review from shivaspeaks July 11, 2025 23:31
shivaspeaks
shivaspeaks approved these changes Jul 12, 2025
View reviewed changes
Copy link
Member

@shivaspeaks shivaspeaks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really appreciate the addition of the config_equalsTester() test case using Guava's EqualsTester. I learned something new today, thanks for the thoroughness Eric!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kannanjgithub kannanjgithub kannanjgithub approved these changes

@shivaspeaks shivaspeaks shivaspeaks approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ejona86 @kannanjgithub @shivaspeaks