11246 :: Unexpected error when server expands a compressed message to learn it is too large #12360
+102
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… learn it is too large
… learn it is too large
vimanikag
changed the title
… learn it is too large
AgraVator
reviewed
Oct 6, 2025
Comment on lines
+816
to
+820
| if (t instanceof StatusRuntimeException) { | ||
| if (((StatusRuntimeException) t).getStatus().getCode() == Status.Code.RESOURCE_EXHAUSTED) { | ||
| statusToPropagate = ((StatusRuntimeException) t).getStatus().withCause(t); | ||
| } | ||
| } |
There was a problem hiding this comment.
This can be refactored to use a single if. But, personally I would extract out the explicit conversion of t into a variable.
| ServerStreamListener mockListener = mock(ServerStreamListener.class); | ||
| listener.setListener(mockListener); | ||
|
|
||
| RuntimeException expectedT = new RuntimeException(); |
Comment on lines
+817
to
+818
| if (((StatusRuntimeException) t).getStatus().getCode() == Status.Code.RESOURCE_EXHAUSTED) { | ||
| statusToPropagate = ((StatusRuntimeException) t).getStatus().withCause(t); |
There was a problem hiding this comment.
Are there no other cases where we can get "RESOURCE_EXHAUSTED" ? As, this is not tied specifically to marshaling the intended behavior can change if and when new "RESOURCE_EXHAUSTED" are added.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes : #11246