-
Notifications
You must be signed in to change notification settings - Fork 3.9k
A68 random subsetting #12377
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Zgoda91
wants to merge
14
commits into
grpc:master
Choose a base branch
from
Zgoda91:A68_random_subsetting
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+773
−1
Open
A68 random subsetting #12377
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
8d349df
Moved `XxHash64` library to enable shared use across projects
Zgoda91 8ec136a
Implemented random_subsetting LB policy
Zgoda91 1870e6f
Implemented random_subsetting converter for xDS
Zgoda91 40af1a8
Optimized seed lifetime
Zgoda91 d78cf20
Optimized memory allocations for arrays
Zgoda91 4dfa2e7
Changed visibility of LB to package-private
Zgoda91 f5147ee
Revert "Moved `XxHash64` library to enable shared use across projects"
Zgoda91 e404564
Changed hashing function to `murmur3_128`
Zgoda91 7684629
Removed leftover dependency from `BUILD.bazel`
Zgoda91 4fbf81d
Changed hash code comparator
Zgoda91 5745d0a
Improved test assertion to get better failure message
Zgoda91 eb06b9e
Excluded new LB from javadoc
Zgoda91 e168032
Improved `subsetSize` parsing
Zgoda91 56d33a7
Adjusted expectation for flaky test
Zgoda91 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
157 changes: 157 additions & 0 deletions
157
util/src/main/java/io/grpc/util/RandomSubsettingLoadBalancer.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,157 @@ | ||
/* | ||
* Copyright 2025 The gRPC Authors | ||
* | ||
* Licensed under the Apache License, Version 2.0 (the "License"); | ||
* you may not use this file except in compliance with the License. | ||
* You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, | ||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
* See the License for the specific language governing permissions and | ||
* limitations under the License. | ||
*/ | ||
|
||
package io.grpc.util; | ||
|
||
import static com.google.common.base.Preconditions.checkArgument; | ||
import static com.google.common.base.Preconditions.checkNotNull; | ||
|
||
import com.google.common.hash.HashCode; | ||
import com.google.common.hash.HashFunction; | ||
import com.google.common.hash.Hashing; | ||
import io.grpc.EquivalentAddressGroup; | ||
import io.grpc.LoadBalancer; | ||
import io.grpc.Status; | ||
import java.nio.charset.StandardCharsets; | ||
import java.util.ArrayList; | ||
import java.util.Collections; | ||
import java.util.Comparator; | ||
import java.util.Random; | ||
|
||
|
||
/** | ||
* Wraps a child {@code LoadBalancer}, separating the total set of backends into smaller subsets for | ||
* the child balancer to balance across. | ||
* | ||
* <p>This implements random subsetting gRFC: | ||
* https://https://github.com/grpc/proposal/blob/master/A68-random-subsetting.md | ||
*/ | ||
final class RandomSubsettingLoadBalancer extends LoadBalancer { | ||
private final GracefulSwitchLoadBalancer switchLb; | ||
private final HashFunction hashFunc; | ||
|
||
public RandomSubsettingLoadBalancer(Helper helper) { | ||
switchLb = new GracefulSwitchLoadBalancer(checkNotNull(helper, "helper")); | ||
int seed = new Random().nextInt(); | ||
hashFunc = Hashing.murmur3_128(seed); | ||
} | ||
|
||
@Override | ||
public Status acceptResolvedAddresses(ResolvedAddresses resolvedAddresses) { | ||
RandomSubsettingLoadBalancerConfig config = | ||
(RandomSubsettingLoadBalancerConfig) | ||
resolvedAddresses.getLoadBalancingPolicyConfig(); | ||
|
||
ResolvedAddresses subsetAddresses = filterEndpoints(resolvedAddresses, config.subsetSize); | ||
|
||
return switchLb.acceptResolvedAddresses( | ||
subsetAddresses.toBuilder() | ||
.setLoadBalancingPolicyConfig(config.childConfig) | ||
.build()); | ||
} | ||
|
||
// implements the subsetting algorithm, as described in A68: | ||
// https://github.com/grpc/proposal/pull/423 | ||
private ResolvedAddresses filterEndpoints(ResolvedAddresses resolvedAddresses, int subsetSize) { | ||
if (subsetSize >= resolvedAddresses.getAddresses().size()) { | ||
return resolvedAddresses; | ||
} | ||
|
||
ArrayList<EndpointWithHash> endpointWithHashList = | ||
new ArrayList<>(resolvedAddresses.getAddresses().size()); | ||
|
||
for (EquivalentAddressGroup addressGroup : resolvedAddresses.getAddresses()) { | ||
endpointWithHashList.add( | ||
new EndpointWithHash( | ||
addressGroup, | ||
hashFunc.hashString( | ||
addressGroup.getAddresses().get(0).toString(), | ||
StandardCharsets.UTF_8))); | ||
} | ||
|
||
Collections.sort(endpointWithHashList, new HashAddressComparator()); | ||
|
||
ArrayList<EquivalentAddressGroup> addressGroups = new ArrayList<>(subsetSize); | ||
|
||
for (int idx = 0; idx < subsetSize; ++idx) { | ||
addressGroups.add(endpointWithHashList.get(idx).addressGroup); | ||
} | ||
|
||
return resolvedAddresses.toBuilder().setAddresses(addressGroups).build(); | ||
} | ||
|
||
@Override | ||
public void handleNameResolutionError(Status error) { | ||
switchLb.handleNameResolutionError(error); | ||
} | ||
|
||
@Override | ||
public void shutdown() { | ||
switchLb.shutdown(); | ||
} | ||
|
||
private static final class EndpointWithHash { | ||
public final EquivalentAddressGroup addressGroup; | ||
public final HashCode hashCode; | ||
|
||
public EndpointWithHash(EquivalentAddressGroup addressGroup, HashCode hashCode) { | ||
this.addressGroup = addressGroup; | ||
this.hashCode = hashCode; | ||
} | ||
} | ||
|
||
private static final class HashAddressComparator implements Comparator<EndpointWithHash> { | ||
@Override | ||
public int compare(EndpointWithHash lhs, EndpointWithHash rhs) { | ||
return Long.compare(lhs.hashCode.asLong(), rhs.hashCode.asLong()); | ||
} | ||
} | ||
|
||
public static final class RandomSubsettingLoadBalancerConfig { | ||
public final int subsetSize; | ||
public final Object childConfig; | ||
|
||
private RandomSubsettingLoadBalancerConfig(int subsetSize, Object childConfig) { | ||
this.subsetSize = subsetSize; | ||
this.childConfig = childConfig; | ||
} | ||
|
||
public static class Builder { | ||
int subsetSize; | ||
Object childConfig; | ||
|
||
public Builder setSubsetSize(long subsetSize) { | ||
checkArgument(subsetSize > 0L, "Subset size must be greater than 0"); | ||
// clamping subset size to Integer.MAX_VALUE due to collection indexing limitations in JVM | ||
long subsetSizeClamped = Math.min(subsetSize, (long) Integer.MAX_VALUE); | ||
// safe narrowing cast due to clamping | ||
this.subsetSize = (int) subsetSizeClamped; | ||
return this; | ||
} | ||
|
||
public Builder setChildConfig(Object childConfig) { | ||
this.childConfig = checkNotNull(childConfig, "childConfig"); | ||
return this; | ||
} | ||
|
||
public RandomSubsettingLoadBalancerConfig build() { | ||
return new RandomSubsettingLoadBalancerConfig( | ||
subsetSize, | ||
checkNotNull(childConfig, "childConfig")); | ||
} | ||
} | ||
} | ||
} |
86 changes: 86 additions & 0 deletions
86
util/src/main/java/io/grpc/util/RandomSubsettingLoadBalancerProvider.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,86 @@ | ||
/* | ||
* Copyright 2025 The gRPC Authors | ||
* | ||
* Licensed under the Apache License, Version 2.0 (the "License"); | ||
* you may not use this file except in compliance with the License. | ||
* You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, | ||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
* See the License for the specific language governing permissions and | ||
* limitations under the License. | ||
*/ | ||
|
||
package io.grpc.util; | ||
|
||
import io.grpc.Internal; | ||
import io.grpc.LoadBalancer; | ||
import io.grpc.LoadBalancerProvider; | ||
import io.grpc.NameResolver.ConfigOrError; | ||
import io.grpc.Status; | ||
import io.grpc.internal.JsonUtil; | ||
import java.util.Map; | ||
|
||
@Internal | ||
public final class RandomSubsettingLoadBalancerProvider extends LoadBalancerProvider { | ||
private static final String POLICY_NAME = "random_subsetting"; | ||
|
||
@Override | ||
public LoadBalancer newLoadBalancer(LoadBalancer.Helper helper) { | ||
return new RandomSubsettingLoadBalancer(helper); | ||
} | ||
|
||
@Override | ||
public boolean isAvailable() { | ||
return true; | ||
} | ||
|
||
@Override | ||
public int getPriority() { | ||
return 5; | ||
} | ||
|
||
@Override | ||
public String getPolicyName() { | ||
return POLICY_NAME; | ||
} | ||
|
||
@Override | ||
public ConfigOrError parseLoadBalancingPolicyConfig(Map<String, ?> rawConfig) { | ||
try { | ||
return parseLoadBalancingPolicyConfigInternal(rawConfig); | ||
} catch (RuntimeException e) { | ||
return ConfigOrError.fromError( | ||
Status.UNAVAILABLE | ||
.withCause(e) | ||
.withDescription("Failed parsing configuration for " + getPolicyName())); | ||
} | ||
} | ||
|
||
private ConfigOrError parseLoadBalancingPolicyConfigInternal(Map<String, ?> rawConfig) { | ||
Long subsetSize = JsonUtil.getNumberAsLong(rawConfig, "subsetSize"); | ||
if (subsetSize == null) { | ||
return ConfigOrError.fromError( | ||
Status.INTERNAL.withDescription( | ||
"Subset size missing in " + getPolicyName() + ", LB policy config=" + rawConfig)); | ||
} | ||
|
||
ConfigOrError childConfig = GracefulSwitchLoadBalancer.parseLoadBalancingPolicyConfig( | ||
JsonUtil.getListOfObjects(rawConfig, "childPolicy")); | ||
if (childConfig.getError() != null) { | ||
return ConfigOrError.fromError(Status.INTERNAL | ||
.withDescription( | ||
"Failed to parse child in " + getPolicyName() + ", LB policy config=" + rawConfig) | ||
.withCause(childConfig.getError().asRuntimeException())); | ||
} | ||
|
||
return ConfigOrError.fromConfig( | ||
new RandomSubsettingLoadBalancer.RandomSubsettingLoadBalancerConfig.Builder() | ||
.setSubsetSize(subsetSize) | ||
.setChildConfig(childConfig.getConfig()) | ||
.build()); | ||
} | ||
} |
1 change: 1 addition & 0 deletions
1
util/src/main/resources/META-INF/services/io.grpc.LoadBalancerProvider
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,2 +1,3 @@ | ||
io.grpc.util.SecretRoundRobinLoadBalancerProvider$Provider | ||
io.grpc.util.OutlierDetectionLoadBalancerProvider | ||
io.grpc.util.RandomSubsettingLoadBalancerProvider |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.