rls: Add route lookup reason to request #12442
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ejona86
reviewed
Oct 24, 2025
| asyncRlsCall(entry.request, entry.backoffPolicy); | ||
| "[RLS Entry {0}] Calling RLS for transition to pending", entry.routeLookupRequestKey); | ||
| linkedHashLruCache.invalidate(entry.routeLookupRequestKey); | ||
| asyncRlsCall(entry.routeLookupRequestKey, entry.backoffPolicy, entry.routeLookupReason); |
There was a problem hiding this comment.
It seems this should always be REASON_MISS, because we have no data for this entry.
| @Immutable | ||
| abstract static class RouteLookupRequest { | ||
|
|
||
| // Names should match those in grpc.lookup.v1.RouteLookupRequest.Reason |
There was a problem hiding this comment.
Convert to javadoc, here and below.
|
|
||
| /** Creates a {@link RouteLookupRequest} using the given request lookup key and reason. */ | ||
| @CheckReturnValue | ||
| RouteLookupRequest create(RouteLookupRequestKey routeLookupRequestKey, |
There was a problem hiding this comment.
I'm not seeing the value of this method; why not just inline its contents into the one caller?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
b/348690462