core: deprecate NR.L and add NR.Results #5486
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhangkun83
reviewed
Mar 22, 2019
| */ | ||
| public void updateNameResolutionError(Status error) { | ||
| throw new UnsupportedOperationException("Not implemented"); | ||
| } |
There was a problem hiding this comment.
Since we have the Observer, these two methods should not be added.
There was a problem hiding this comment.
Sorry, removed.
| * | ||
| * @since 1.20.0 | ||
| */ | ||
| @ResolutionResultAttr |
There was a problem hiding this comment.
Maybe rename Result to ResolutionResult to match the annotation name.
| @@ -38,10 +38,16 @@ public String getServiceAuthority() { | |||
| } | |||
|
|
|||
| @Override | |||
| @SuppressWarnings("deprecation") | |||
|
|
||
|
|
||
| @Test | ||
| @SuppressWarnings("deprecation") // this will be removed in 1.21.0 |
There was a problem hiding this comment.
This shouldn't be necessary.
| */ | ||
| public void updateNameResolutionError(Status error) { | ||
| throw new UnsupportedOperationException("Not implemented"); | ||
| } |
There was a problem hiding this comment.
Sorry, removed.
| * | ||
| * @since 1.20.0 | ||
| */ | ||
| @ResolutionResultAttr |
| @@ -38,10 +38,16 @@ public String getServiceAuthority() { | |||
| } | |||
|
|
|||
| @Override | |||
| @SuppressWarnings("deprecation") | |||
|
|
||
|
|
||
| @Test | ||
| @SuppressWarnings("deprecation") // this will be removed in 1.21.0 |
zhangkun83
approved these changes
Mar 22, 2019
| * | ||
| * @since 1.20.0 | ||
| */ | ||
| @ExperimentalApi("FIXME") |
There was a problem hiding this comment.
You can use NameResolver's tracking issue: #1770
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.