[CloudRun] Implement Cloudrun to Cloudrun test #164
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
sergiitk
reviewed
Apr 29, 2025
Member
sergiitk
left a comment
sergiitk
left a comment
There was a problem hiding this comment.
LGTM, but I'd like to have another look before merging
framework/test_app/runners/cloud_run/cloud_run_xds_client_runner.py
Outdated
Show resolved
Hide resolved
framework/test_app/runners/cloud_run/cloud_run_xds_client_runner.py
Outdated
Show resolved
Hide resolved
framework/test_app/runners/cloud_run/cloud_run_xds_client_runner.py
Outdated
Show resolved
Hide resolved
framework/test_app/runners/cloud_run/cloud_run_xds_client_runner.py
Outdated
Show resolved
Hide resolved
framework/test_app/runners/cloud_run/cloud_run_xds_client_runner.py
Outdated
Show resolved
Hide resolved
sergiitk
requested changes
May 1, 2025
Member
sergiitk
left a comment
sergiitk
left a comment
There was a problem hiding this comment.
We need to get rid of granting roles/run.invoker to allUsers. See my comment on policy_body with further explanations.
framework/test_app/runners/cloud_run/cloud_run_xds_client_runner.py
Outdated
Show resolved
Hide resolved
framework/test_app/runners/cloud_run/cloud_run_xds_client_runner.py
Outdated
Show resolved
Hide resolved
sergiitk
reviewed
May 6, 2025
Member
sergiitk
left a comment
sergiitk
left a comment
There was a problem hiding this comment.
I'm getting the following error.
Traceback (most recent call last):
File "/Users/sergiitk/Development/psm-interop/tests/cloud_run_csm_outbound_test.py", line 74, in test_cloud_run_to_cloud_run
self.assertXdsConfigExistsWithRetry(
File "/Users/sergiitk/Development/psm-interop/framework/xds_k8s_testcase.py", line 591, in assertXdsConfigExistsWithRetry
retryer(
File "/Users/sergiitk/Development/psm-interop/venv/lib/python3.10/site-packages/tenacity/__init__.py", line 423, in __call__
do = self.iter(retry_state=retry_state)
File "/Users/sergiitk/Development/psm-interop/venv/lib/python3.10/site-packages/tenacity/__init__.py", line 369, in iter
return self.retry_error_callback(retry_state=retry_state)
File "/Users/sergiitk/Development/psm-interop/framework/helpers/retryers.py", line 147, in error_handler
raise RetryError(
framework.helpers.retryers.RetryError: Retry error calling framework.xds_k8s_testcase.XdsKubernetesBaseTestCase.assertXdsConfigExists: timeout 0:10:00 (h:mm:ss) exceeded. Last exception: AssertionError: unexpectedly None
Could not find correct bootstrap config before timeout 0:10:00 (h:mm:ss)
framework/test_app/runners/cloud_run/cloud_run_xds_client_runner.py
Outdated
Show resolved
Hide resolved
framework/test_app/runners/cloud_run/cloud_run_xds_client_runner.py
Outdated
Show resolved
Hide resolved
Member
sergiitk
approved these changes
May 7, 2025
sergiitk
changed the title
Member
Author
Member
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests the case where the client and the server are running in cloudrun. Verifies that 100 RPCs reach the server correctly and return with the correct response.