Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing handling of Ctrl+c #62

Merged
merged 1 commit into from
May 9, 2024
Merged

Removing handling of Ctrl+c #62

merged 1 commit into from
May 9, 2024

Conversation

gr211
Copy link
Contributor

@gr211 gr211 commented May 9, 2024

Why

Specific handling of ctrl+c signal was counter productive on heavily loaded streams.

I used a boolean to exit the loop faster, but it was still pausing for a few seconds. A bigger overhaul would have been to pass that boolean to all shard consumers as well (ie not just the sink).

A possible alternative could be the usage of priority queues (to handle Termination signal faster).

But all in all, it now appears a counter productive handling in the sense a typical unix command would immediately exit with code 130. There is no valid reason to make kinesis-tailr behave any differently.

@gr211 gr211 self-assigned this May 9, 2024
@gr211 gr211 merged commit e90df9f into main May 9, 2024
1 check passed
@gr211 gr211 deleted the bugfix_exiting branch May 9, 2024 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant