Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Specific handling of
ctrl+c
signal was counter productive on heavily loaded streams.I used a boolean to exit the loop faster, but it was still pausing for a few seconds. A bigger overhaul would have been to pass that boolean to all shard consumers as well (ie not just the sink).
A possible alternative could be the usage of priority queues (to handle Termination signal faster).
But all in all, it now appears a counter productive handling in the sense a typical unix command would immediately exit with code 130. There is no valid reason to make
kinesis-tailr
behave any differently.