Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add named save states widget, disable menu entries for numbered/quick… #1466

Merged
merged 2 commits into from
Nov 23, 2023

Conversation

Giragast
Copy link
Contributor

Allows for save states to be given names (beyond appending 0-9) and be created, overwritten, loaded & deleted within a bespoke widget

The naming format is [GAMEID]_[NAME_OF_SAVE_STATE].sstate

These named save states are also listed in the File->Load save slots menu

This PR also disables menu items for save states that don't have an existing file to load, helping to indicate at a glance which are currently in use

@ghost
Copy link

ghost commented Nov 22, 2023

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

Copy link

codecov bot commented Nov 22, 2023

Codecov Report

Attention: 142 lines in your changes are missing coverage. Please review.

Comparison is base (a072e38) 8.59% compared to head (948bdca) 8.59%.
Report is 2 commits behind head on main.

Files Patch % Lines
src/gui/widgets/named_savestates.cc 0.00% 101 Missing ⚠️
src/gui/gui.cc 0.00% 40 Missing ⚠️
src/gui/widgets/named_savestates.h 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1466      +/-   ##
==========================================
- Coverage    8.59%    8.59%   -0.01%     
==========================================
  Files         408      410       +2     
  Lines      125609   125742     +133     
==========================================
  Hits        10802    10802              
- Misses     114807   114940     +133     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nicolasnoble nicolasnoble merged commit f029c42 into grumpycoders:main Nov 23, 2023
13 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants