Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding better cd patching web server messages. #1469

Merged

Conversation

nicolasnoble
Copy link
Member

No description provided.

@ghost
Copy link

ghost commented Nov 26, 2023

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

Copy link

codecov bot commented Nov 26, 2023

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (a766fe2) 8.67% compared to head (87c73d2) 8.66%.

Files Patch % Lines
src/core/web-server.cc 0.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1469      +/-   ##
==========================================
- Coverage    8.67%    8.66%   -0.01%     
==========================================
  Files         413      413              
  Lines      125847   125852       +5     
==========================================
  Hits        10911    10911              
- Misses     114936   114941       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nicolasnoble nicolasnoble merged commit 908556d into grumpycoders:main Nov 26, 2023
14 of 16 checks passed
@nicolasnoble nicolasnoble deleted the better-webserver-messages branch November 26, 2023 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant