Fixing lost IRQ problem. #1498
Merged
Fixing lost IRQ problem. #1498
CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (main)
failed
Dec 20, 2023 in 30s
CodeScene PR Check
❌ Code Health Quality Gates: FAILED
- Declining Code Health: 3 findings(s) 🚩
- Improving Code Health: 0 findings(s) ✅
- Affected Hotspots: 0 files(s) 🔥
Recommended Review Level: Detailed -- Inspect the code that degrades in code health.
View detailed results in CodeScene
Details
🚩 Declining Code Health (highest to lowest):
- Complex Method irq.c: IRQVerifier
- Bumpy Road Ahead irq.c: IRQVerifier
- Complex Method irq.c: IRQVerifier
Annotations
Check warning on line 125 in src/mips/openbios/handlers/irq.c
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
❌ Getting worse: Complex Method
IRQVerifier increases in cyclomatic complexity from 14 to 23, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.
Check warning on line 65 in src/mips/openbios/handlers/irq.c
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
❌ New issue: Complex Method
IRQVerifier has a cyclomatic complexity of 14, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.
Check warning on line 124 in src/mips/openbios/handlers/irq.c
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
❌ New issue: Bumpy Road Ahead
IRQVerifier has 11 blocks with nested conditional logic. Any nesting of 2 or deeper is considered. Threshold is one single, nested block per function. The Bumpy Road code smell is a function that contains multiple chunks of nested conditional logic. The deeper the nesting and the more bumps, the lower the code health.
Loading