Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Chores] Format code #1787

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[Chores] Format code #1787

wants to merge 1 commit into from

Conversation

nicolasnoble
Copy link
Member

@nicolasnoble nicolasnoble commented Oct 22, 2024

Automated changes by create-pull-request GitHub action

@nicolasnoble nicolasnoble force-pushed the chores-code-format branch 4 times, most recently from 4d2b6af to 872528d Compare October 24, 2024 05:17
@nicolasnoble nicolasnoble force-pushed the chores-code-format branch 3 times, most recently from 1feada4 to 083e040 Compare November 6, 2024 12:41
@nicolasnoble nicolasnoble force-pushed the chores-code-format branch 5 times, most recently from 2d20399 to 54ffd6e Compare November 18, 2024 02:15
@nicolasnoble nicolasnoble force-pushed the chores-code-format branch 5 times, most recently from e1235d7 to b71baa2 Compare November 23, 2024 03:46
Copy link

codecov bot commented Nov 28, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 9.20%. Comparing base (d2bf4f7) to head (8dbd555).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
src/core/pcsxlua.cc 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1787      +/-   ##
==========================================
- Coverage    9.20%    9.20%   -0.01%     
==========================================
  Files         467      467              
  Lines      143962   143972      +10     
==========================================
  Hits        13250    13250              
- Misses     130712   130722      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nicolasnoble nicolasnoble force-pushed the chores-code-format branch 3 times, most recently from 0437a24 to 18cc174 Compare December 17, 2024 06:22
@nicolasnoble nicolasnoble force-pushed the chores-code-format branch 2 times, most recently from 1501b83 to 68dff0b Compare December 24, 2024 01:48
@nicolasnoble nicolasnoble force-pushed the chores-code-format branch 5 times, most recently from 8dbd555 to 76b53c6 Compare December 30, 2024 16:10
@nicolasnoble nicolasnoble force-pushed the chores-code-format branch 5 times, most recently from c95deb0 to cce95e1 Compare January 5, 2025 04:06
Copy link

coderabbitai bot commented Jan 5, 2025

Walkthrough

This pull request introduces a series of minor formatting and style adjustments across multiple source files in the project. The changes primarily focus on consistent code styling, including the removal of extraneous spaces in pointer declarations, adjustments to template parameter formatting, and corrections in pointer casting syntax. Additionally, a new line was added to invoke a method in the emulator class. These modifications do not alter the functionality or logic of the codebase but aim to enhance code readability and maintain a uniform coding style.

Changes

File Change Summary
src/core/pcsxlua.cc Removed extraneous space in getCPUCycles function return statement
src/core/psxemulator.cc Added m_pads->setLua(L) call in setLua method
src/mips/common/crt0/cxxglue.c Updated pointer declaration spacing in function signatures
src/mips/psyqo/bump-allocator.h Adjusted template parameter list formatting
src/mips/psyqo/examples/cube/cube.cpp Corrected pointer casting syntax spacing
src/mips/psyqo/iso9660-parser.hh Reorganized <coroutine> header inclusion
src/mips/psyqo/primitives/common.hh Removed space before enum class Transparency declaration

Poem

🐰 A Rabbit's Code Style Delight 🌟

Spaces trimmed with gentle might,
Pointers aligned, oh so right!
Commas dance, templates gleam,
Our code now flows like a dream
Consistency is our rabbit's art! 🎨


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 55ac76f and 95e88bf.

📒 Files selected for processing (7)
  • src/core/pcsxlua.cc (1 hunks)
  • src/core/psxemulator.cc (1 hunks)
  • src/mips/common/crt0/cxxglue.c (2 hunks)
  • src/mips/psyqo/bump-allocator.h (1 hunks)
  • src/mips/psyqo/examples/cube/cube.cpp (2 hunks)
  • src/mips/psyqo/iso9660-parser.hh (1 hunks)
  • src/mips/psyqo/primitives/common.hh (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (7)
  • src/core/pcsxlua.cc
  • src/mips/psyqo/iso9660-parser.hh
  • src/core/psxemulator.cc
  • src/mips/psyqo/primitives/common.hh
  • src/mips/psyqo/examples/cube/cube.cpp
  • src/mips/psyqo/bump-allocator.h
  • src/mips/common/crt0/cxxglue.c

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant