CodeScene PR Check
β Code Health Quality Gates: FAILED
- Declining Code Health: 4 findings(s) π©
- Improving Code Health: 1 findings(s) β
- Affected Hotspots: 2 files(s) π₯
Recommended Review Level: Detailed -- Inspect the code that degrades in code health.
View detailed results in CodeScene
Details
π© Declining Code Health (highest to lowest):
- Complex Method debug.cc: PCSX::SPU::impl::debug
- Large Method pad.cc: PadsImpl::setLua π₯
- Complex Method gpu.cc: drawLogNode
- Complex Method gpu.cc: drawLogNode
β Improving Code Health:
- Lines of Code in a Single File gui.cc π₯
Annotations
Check notice on line 1 in src/core/gpu.cc
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
βΉ Getting worse: Lines of Code in a Single File
The lines of code increases from 1152 to 1154, improve code health by reducing it to 1000. The number of Lines of Code in a single file. More Lines of Code lowers the code health.
Check warning on line 1103 in src/core/gpu.cc
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
β Getting worse: Complex Method
drawLogNode already has high cyclomatic complexity, and now it increases in Lines of Code from 84 to 85. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.
Check warning on line 1200 in src/core/gpu.cc
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
β Getting worse: Complex Method
drawLogNode already has high cyclomatic complexity, and now it increases in Lines of Code from 84 to 85. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.
Check notice on line 1 in src/core/pad.cc
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
βΉ Getting worse: Lines of Code in a Single File
The lines of code increases from 1047 to 1057, improve code health by reducing it to 1000. The number of Lines of Code in a single file. More Lines of Code lowers the code health.
Check warning on line 1374 in src/core/pad.cc
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
β Getting worse: Large Method
PadsImpl::setLua increases from 124 to 134 lines of code, threshold = 70. Large functions with many lines of code are generally harder to understand and lower the code health. Avoid adding more lines to this function.
Check notice on line 1 in src/gui/gui.cc
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
β Getting better: Lines of Code in a Single File
The lines of code decreases from 1960 to 1958, improve code health by reducing it to 1000. The number of Lines of Code in a single file. More Lines of Code lowers the code health.
Check notice on line 119 in src/gui/widgets/named_savestates.cc
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
βΉ Getting worse: Complex Method
PCSX::Widgets::NamedSaveStates::draw already has high cyclomatic complexity, and now it increases in Lines of Code from 98 to 100. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.
Check warning on line 138 in src/spu/debug.cc
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
β Getting worse: Complex Method
PCSX::SPU::impl::debug already has high cyclomatic complexity, and now it increases in Lines of Code from 142 to 143. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.