Add More Options to Configure Italicization #185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this commit, it was possible to enable italicization of strings and comments. This seems fairly arbitrary as users (myself included) may want to choose settings other than these. For instance, some other themes use italicization to separate keywords, or other language-specific patterns. While this may not be of interest to everyone, it seems reasonable to allow it to be configurable. This patch therefore introduces the following configuration options: - g:gruvbox_italicize_statements - g:gruvbox_italicize_conditionals - g:gruvbox_italicize_repeats - g:gruvbox_italicize_label - g:gruvbox_italicize_exceptions - g:gruvbox_italicize_keywords
italicize_comments previously was coded differently to the other italicization checks. This patch simply brings it into line without changing the functionality.
|
It seems not obvious to me if these should be options or not. It may be better to focus on a couple recommended highlight groups to enable italics for and leave the rest to I will leave this open to more feedback - I don't use italics. Just wanted to share that it's not obvious to me if we should merge. |
|
@rbong completely fair and understandable, especially to avoid ongoing creep in the amount of options. If there's interest in adding some more customisation, but in a more palatable form, then I'd be more than happy to change the mechanism through which this happens. I'll go back and see if I can think of something different that may work better. Thanks for the feedback! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this commit, it was possible to enable italicization of strings and comments. This seems fairly arbitrary as users (myself included) may want to choose settings other than these. For instance, some other themes use italicization to separate keywords, or other language-specific patterns. While this may not be of interest to everyone, it seems reasonable to allow it to be configurable.
This patch therefore introduces the following configuration options:
g:gruvbox_italicize_statementsg:gruvbox_italicize_conditionalsg:gruvbox_italicize_repeatsg:gruvbox_italicize_labelg:gruvbox_italicize_exceptionsg:gruvbox_italicize_keywordsIf this is an acceptable change, I'm happy to also update the wiki documentation to match.