Merge pull request #185 from gruz0/refactor/reorganize-plausible-goals

Reorganize Plausible goals
gruz0 · Nov 24, 2024 · 80ddda3 · 80ddda3
2 parents 7d241b8 + f99cbd3
commit 80ddda3
Show file tree

Hide file tree

Showing 5 changed files with 30 additions and 6 deletions.
diff --git a/src/app/concepts/[id]/ProblemRequiresChanges.tsx b/src/app/concepts/[id]/ProblemRequiresChanges.tsx
@@ -6,6 +6,7 @@ import React, { useState } from 'react'
 import ConceptForm from '@/components/ConceptForm'
 import Paragraph from '@/components/Paragraph'
 import Section from '@/components/Section'
+import { Goals } from '@/lib/goals'
 
 interface TargetAudience {
   segment: string
@@ -43,8 +44,9 @@ const ProblemRequiresChanges = ({ conceptId, problem, evaluation }: Props) => {
       setStatus('loading')
       setErrorMessage(null)
 
-      plausible('analysis', {
+      plausible(Goals.Analysis, {
         props: {
+          page: 'ProblemRequiresChanges',
           buttonId: 'requires_changes',
         },
       })

diff --git a/src/app/concepts/[id]/WellDefinedProblem.tsx b/src/app/concepts/[id]/WellDefinedProblem.tsx
@@ -5,6 +5,7 @@ import React, { useState } from 'react'
 import Paragraph from '@/components/Paragraph'
 import Section from '@/components/Section'
 import SimpleUnorderedList from '@/components/SimpleUnorderedList'
+import { Goals } from '@/lib/goals'
 
 interface TargetAudience {
   segment: string
@@ -41,8 +42,9 @@ const WellDefinedProblem = ({ conceptId, evaluation }: Props) => {
       setStatus('loading')
       setErrorMessage(null)
 
-      plausible('analysis', {
+      plausible(Goals.Analysis, {
         props: {
+          page: 'WellDefinedProblem',
           buttonId: 'well_defined',
         },
       })

diff --git a/src/app/ideas/[id]/IdeaAnalysisReport.tsx b/src/app/ideas/[id]/IdeaAnalysisReport.tsx
@@ -8,6 +8,7 @@ import BackToTopButton from '@/components/BackToTopButton'
 import FeedbackForm from '@/components/FeedbackForm'
 import HorizontalLine from '@/components/HorizontalLine'
 import MessageBox from '@/components/MessageBox'
+import { Goals } from '@/lib/goals'
 import { NavBar } from './components/NavBar'
 import SectionActionableNextSteps from './components/SectionActionableNextSteps'
 import SectionCompetitors from './components/SectionCompetitors'
@@ -159,7 +160,7 @@ export const IdeaAnalysisReport = ({ data }: Props) => {
     }
 
     try {
-      plausible('archive_report')
+      plausible(Goals.ArchiveReport)
 
       const res = await fetch(`/api/ideas/${data.id}`, {
         method: 'DELETE',
@@ -243,7 +244,13 @@ export const IdeaAnalysisReport = ({ data }: Props) => {
             {readyForReport ? (
               <Link
                 href={`/api/ideas/${data.id}/pdf`}
-                onClick={() => plausible('download_pdf')}
+                onClick={() =>
+                  plausible(Goals.DownloadPDF, {
+                    props: {
+                      buttonId: 'top_button',
+                    },
+                  })
+                }
                 target="_blank"
                 className="rounded bg-blue-600 px-4 py-2 font-semibold text-white hover:bg-blue-700"
               >
@@ -345,7 +352,13 @@ export const IdeaAnalysisReport = ({ data }: Props) => {
             {readyForReport ? (
               <Link
                 href={`/api/ideas/${data.id}/pdf`}
-                onClick={() => plausible('download_pdf')}
+                onClick={() =>
+                  plausible(Goals.DownloadPDF, {
+                    props: {
+                      buttonId: 'bottom_button',
+                    },
+                  })
+                }
                 target="_blank"
                 className="rounded bg-blue-600 px-4 py-2 font-semibold text-white hover:bg-blue-700"
               >

diff --git a/src/app/ideas/[id]/social_media_campaigns/SocialMediaCampaigns.tsx b/src/app/ideas/[id]/social_media_campaigns/SocialMediaCampaigns.tsx
@@ -7,6 +7,7 @@ import BackToTopButton from '@/components/BackToTopButton'
 import FeedbackForm from '@/components/FeedbackForm'
 import FetchingDataMessage from '@/components/FetchingDataMessage'
 import HorizontalLine from '@/components/HorizontalLine'
+import { Goals } from '@/lib/goals'
 import { NavBar } from './components/NavBar'
 import SectionLongFormContent from './components/SectionLongFormContent'
 import SectionShortFormContent from './components/SectionShortFormContent'
@@ -105,7 +106,7 @@ export const SocialMediaCampaigns = ({ data }: Props) => {
     setStatus('loading')
 
     try {
-      plausible('request_social_media_campaigns')
+      plausible(Goals.RequestSocialMediaCampaigns)
 
       const res = await fetch(`/api/ideas/${data.id}/social_media_campaigns`, {
         method: 'POST',

diff --git a/src/lib/goals.ts b/src/lib/goals.ts
@@ -0,0 +1,6 @@
+export enum Goals {
+  Analysis = 'analysis',
+  DownloadPDF = 'download_pdf',
+  ArchiveReport = 'archive_report',
+  RequestSocialMediaCampaigns = 'request_social_media_campaigns',
+}