Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V1 #15

Merged
merged 1 commit into from
Oct 11, 2024
Merged

V1 #15

merged 1 commit into from
Oct 11, 2024

Conversation

gruz0
Copy link
Owner

@gruz0 gruz0 commented Oct 11, 2024

No description provided.

} catch (error) {
console.error('Error while creating the idea:', error)

return NextResponse.json(
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Handle application errors (service layer) and return a valid HTTP status code

<h1 className="mb-6 text-4xl font-bold">Product Idea Report</h1>

<hr className="my-8" />

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a spinner to show a loading progress. Also refresh a page every 15 seconds until we get all responses.

we&apos;ll help refine it in the next step.
</p>

<form onSubmit={handleSubmit} className="space-y-6">
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extract client form to a single component

title: 'Create Next App',
description: 'Generated by create next app',
title: 'CheckMVP',
description: 'Validate Your Product Idea',
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add SEO and Open Graph tags

@gruz0 gruz0 mentioned this pull request Oct 11, 2024

export interface ContentAndLongTermStrategy {
valueProposition: string
mvpRecommendation: {
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extract interfaces

@gruz0 gruz0 mentioned this pull request Oct 11, 2024
}

private async handleDomainEvents(idea: Idea): Promise<void> {
for (const event of idea.getDomainEvents()) {
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dispatch events through events service (pub/sub), instead of handling it manually.

idea.clearDomainEvents()
}

private async enqueueIdeaAndTargetAudienceEvaluation(
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extract all these enqueue methods into subscribers.

@gruz0 gruz0 merged commit 09b8c7d into master Oct 11, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant