-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
V1 #15
V1 #15
Conversation
} catch (error) { | ||
console.error('Error while creating the idea:', error) | ||
|
||
return NextResponse.json( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Handle application errors (service layer) and return a valid HTTP status code
<h1 className="mb-6 text-4xl font-bold">Product Idea Report</h1> | ||
|
||
<hr className="my-8" /> | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add a spinner to show a loading progress. Also refresh a page every 15 seconds until we get all responses.
we'll help refine it in the next step. | ||
</p> | ||
|
||
<form onSubmit={handleSubmit} className="space-y-6"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Extract client form to a single component
title: 'Create Next App', | ||
description: 'Generated by create next app', | ||
title: 'CheckMVP', | ||
description: 'Validate Your Product Idea', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add SEO and Open Graph tags
|
||
export interface ContentAndLongTermStrategy { | ||
valueProposition: string | ||
mvpRecommendation: { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Extract interfaces
} | ||
|
||
private async handleDomainEvents(idea: Idea): Promise<void> { | ||
for (const event of idea.getDomainEvents()) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dispatch events through events service (pub/sub), instead of handling it manually.
idea.clearDomainEvents() | ||
} | ||
|
||
private async enqueueIdeaAndTargetAudienceEvaluation( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Extract all these enqueue
methods into subscribers.
No description provided.