Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add region to concept #260

Merged
merged 3 commits into from
Jan 26, 2025
Merged

Add region to concept #260

merged 3 commits into from
Jan 26, 2025

Conversation

gruz0
Copy link
Owner

@gruz0 gruz0 commented Jan 26, 2025

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Jan 26, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 84.78261% with 7 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/concept/domain/Aggregate.ts 16.66% 5 Missing ⚠️
src/concept/adapters/ConceptRepositorySQLite.ts 0.00% 1 Missing ⚠️
src/concept/app/commands/EvaluateConcept.ts 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Files with missing lines Coverage Δ
src/app/api/concepts/[id]/reservation/errors.ts 100.00% <100.00%> (ø)
src/app/api/concepts/[id]/reservation/route.ts 100.00% <100.00%> (ø)
...concept/adapters/OpenAIService/ConceptEvaluator.ts 94.64% <ø> (ø)
src/concept/domain/Region.ts 100.00% <100.00%> (ø)
.../events/subscribers/ConceptEvaluationSubscriber.ts 31.03% <ø> (ø)
src/concept/adapters/ConceptRepositorySQLite.ts 8.33% <0.00%> (ø)
src/concept/app/commands/EvaluateConcept.ts 38.88% <0.00%> (ø)
src/concept/domain/Aggregate.ts 5.26% <16.66%> (ø)

... and 17 files with indirect coverage changes

@gruz0
Copy link
Owner Author

gruz0 commented Jan 26, 2025

#197

@gruz0 gruz0 merged commit bf223a7 into master Jan 26, 2025
6 checks passed
@gruz0 gruz0 deleted the feature/add-region-to-concept branch January 26, 2025 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants