forked from dagster-io/dagster
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Add pre-push hook to run
make quick_pyright
(dagster-io#12115)
### Summary & Motivation Internal companion PR: dagster-io/internal#8967 This adds a pre-commit hook that runs scripts/run-pyright.py --diff on push only. On my machine it takes ~2 seconds for a commit with several updated python files. Significantly slower than black/ruff but IMO worth it for push. In order to active this, devs must run `pre-commit install --hook-type pre-push`. ### How I Tested These Changes I tried to push a type error in this PR and the hook worked.
- Loading branch information
Showing
2 changed files
with
16 additions
and
2 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters