Minor fixes #153
Merged
Minor fixes #153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Duttenheim
commented
Jun 16, 2023
•
Duttenheim
commented
- Adds pinned array, a type of array which handles virtual memory manually by binding memory pages when needed.
- Merged ArrayStack into Array, and alias it as StackArray. All instances of ArrayStack should be replaced with StackArray.
- Simplified SystemInfo to not be a singleton but merely a collection of 4 globals.
- Added new constructors to ResourceTable binding structs, allowing us to use more shorthands for when we don't need to specify sampler and if the binding uses depth or stencil.
Duttenheim
added
enhancement
Duttenheim
force-pushed
the
minor-fixes
branch
2 times, most recently
from
5a52a30
to
2937238
Compare
Allows for simpler resource table bindings. Removed a bunch of empty lines. Changed the copyright of imgui.fx to be in line with most files.
A pinned array is an array which handles it's physical memory manually. Instead of relying on new/free, it commits pages to virtual memory addresses when needed, ensuring pointer to objects remain valid when the array grows or shrinks in size.
Simplified pinned allocation by removing the numCommittedPages, which can be calculated when needed.
Use normal name for array new and array free
Remove warning of size conversion from size_t to SizeT. Make sure even an array initialized with nullptr has capacity set to stack size. Move from a stack array should move each element and not the pointer over.
…K_SIZE> (aka ArrayStack)
…d effectively cause a copy from the stack buffer where there are no elements.
Duttenheim
force-pushed
the
minor-fixes
branch
from
c8a2f1f
to
45f2418
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.